Re: [PATCH 05/17] net/dpaa: support Tx confirmation to enable PTP

[Hemant Agrawal <hemant.agrawal@oss.nxp.com>]

On 07-08-2024 21:08, Ferruh Yigit wrote:
> On 8/1/2024 11:53 AM, Hemant Agrawal wrote:
>> From: Vanshika Shukla <vanshika.shukla@nxp.com>
>>
>> TX confirmation provides dedicated confirmation
>> queues for transmitted packets. These queues are
>> used by software to get the status and release
>> transmitted packets buffers.
>>
>> Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   drivers/net/dpaa/dpaa_ethdev.c | 45 ++++++++++++++++++++++-------
>>   drivers/net/dpaa/dpaa_ethdev.h |  3 +-
>>   drivers/net/dpaa/dpaa_rxtx.c   | 52 ++++++++++++++++++++++++++++++++++
>>   drivers/net/dpaa/dpaa_rxtx.h   |  2 ++
>>   4 files changed, 90 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
>> index 90b34e42f2..9ffb8c578c 100644
>> --- a/drivers/net/dpaa/dpaa_ethdev.c
>> +++ b/drivers/net/dpaa/dpaa_ethdev.c
>> @@ -1826,9 +1826,15 @@ static int dpaa_tx_queue_init(struct qman_fq *fq,
>>   	opts.fqd.dest.wq = DPAA_IF_TX_PRIORITY;
>>   	opts.fqd.fq_ctrl = QM_FQCTRL_PREFERINCACHE;
>>   	opts.fqd.context_b = 0;
>> +#if defined(RTE_LIBRTE_IEEE1588)
>> +	opts.fqd.context_a.lo = 0;
>> +	opts.fqd.context_a.hi = fman_dealloc_bufs_mask_hi;
>> +#else
>>
> There is already a target to remove 'RTE_LIBRTE_IEEE1588' macro [1],
> waiting for drivers clean up, lets not introduce more of it.
>
> Can you use runtime configuration to enable PTP support?
>
OK, we have made it device args based control.
>
>
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20230203132810.14187-1-thomas@monjalon.net/