From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC564A04F0; Mon, 13 Jan 2020 09:29:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3DDB44C3; Mon, 13 Jan 2020 09:29:36 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8081628F3 for ; Mon, 13 Jan 2020 09:29:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 00:29:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="219237360" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 13 Jan 2020 00:29:34 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 00:29:34 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 13 Jan 2020 16:29:32 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Mon, 13 Jan 2020 16:29:32 +0800 From: "Wang, Haiyue" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "stephen@networkplumber.org" , "Zhang, Qi Z" , "Yang, Qiming" Thread-Topic: [PATCH v3] net/ice: use the copy API to do MAC assignment Thread-Index: AQHVweKtnHiScHyUS0Wa+Emw3n2d7Kfnxq4AgACMpIA= Date: Mon, 13 Jan 2020 08:29:32 +0000 Message-ID: References: <20200102071457.106137-1-haiyue.wang@intel.com> <20200103025845.12609-1-haiyue.wang@intel.com> <20200113080556.GB59121@intel.com> In-Reply-To: <20200113080556.GB59121@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ice: use the copy API to do MAC assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, January 13, 2020 16:06 > To: Wang, Haiyue > Cc: dev@dpdk.org; stephen@networkplumber.org; Zhang, Qi Z ; Yang, Qiming > > Subject: Re: [PATCH v3] net/ice: use the copy API to do MAC assignment >=20 > Hi, haiyue >=20 > On 01/03, Haiyue Wang wrote: > >Use the API rte_ether_addr_copy to do MAC assignment, instead of > >calling rte_memcpy function directly. >=20 > Please add Fix tags and cc stable. >=20 Done in v4. > Thanks, > Xiaolong > > > >Signed-off-by: Haiyue Wang > >--- > >v3: Update the commit message > > > >v2: Update the commit title and message, use the rte_ether_addr_copy API > > instead of just changing the length definition to make code style cl= ean. > > > > drivers/net/ice/ice_ethdev.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > >diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > >index 2cbd82c94..d104df26f 100644 > >--- a/drivers/net/ice/ice_ethdev.c > >+++ b/drivers/net/ice/ice_ethdev.c > >@@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct rte_e= ther_addr *mac_addr) > > ret =3D -ENOMEM; > > goto DONE; > > } > >- rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN); > >+ rte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr); > > TAILQ_INSERT_TAIL(&vsi->mac_list, f, next); > > vsi->mac_num++; > > > >@@ -1660,16 +1660,16 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_ty= pe type) > > > > if (type =3D=3D ICE_VSI_PF) { > > /* MAC configuration */ > >- rte_memcpy(pf->dev_addr.addr_bytes, > >- hw->port_info->mac.perm_addr, > >- ETH_ADDR_LEN); > >+ rte_ether_addr_copy((struct rte_ether_addr *) > >+ hw->port_info->mac.perm_addr, > >+ &pf->dev_addr); > > > >- rte_memcpy(&mac_addr, &pf->dev_addr, RTE_ETHER_ADDR_LEN); > >+ rte_ether_addr_copy(&pf->dev_addr, &mac_addr); > > ret =3D ice_add_mac_filter(vsi, &mac_addr); > > if (ret !=3D ICE_SUCCESS) > > PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter"); > > > >- rte_memcpy(&mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); > >+ rte_ether_addr_copy(&broadcast, &mac_addr); > > ret =3D ice_add_mac_filter(vsi, &mac_addr); > > if (ret !=3D ICE_SUCCESS) > > PMD_INIT_LOG(ERR, "Failed to add MAC filter"); > >@@ -3267,7 +3267,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev= , > > PMD_DRV_LOG(ERR, "Failed to add mac filter"); > > return -EIO; > > } > >- memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN); > >+ rte_ether_addr_copy(mac_addr, &pf->dev_addr); > > > > flags =3D ICE_AQC_MAN_MAC_UPDATE_LAA_WOL; > > ret =3D ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags, NULL)= ; > >-- > >2.17.1 > >