From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07C54A04B5; Thu, 1 Oct 2020 00:17:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9815E1D5A5; Thu, 1 Oct 2020 00:17:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7C0201D5A5 for ; Thu, 1 Oct 2020 00:17:44 +0200 (CEST) IronPort-SDR: eOSsCpFI6ORe/NRgcv3d7vzYy6T7RvXGLGPPpIaabCzpMzu3NnHN492wVB1Xm6mnIzljwKMtvL jsAWht34d56Q== X-IronPort-AV: E=McAfee;i="6000,8403,9760"; a="141966926" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="141966926" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 15:17:37 -0700 IronPort-SDR: KR0ekmG7gB8J2M7YHftJ4mvTCBiQtXIaD8hd/3wtZQUrXFnIZkEE6I3Zb7MtyUMTdIgi5yVcr6 j/J/y0mTcbfw== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="312752642" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.39]) ([10.213.229.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 15:17:36 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20200929205935.20432-1-ajit.khaparde@broadcom.com> <20200929205935.20432-3-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: Date: Wed, 30 Sep 2020 23:17:32 +0100 MIME-Version: 1.0 In-Reply-To: <20200929205935.20432-3-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: update HWRM structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 9:59 PM, Ajit Khaparde wrote: > HWRM API to a newer 1.10.1.70 version. > > Few fields have been renamed because of this. > rx_err_pkt -> rx_discard_pkts > rx_drop_pkts -> rx_error_pkts > > tx_err_pkts -> tx_discard_pkts > tx_drop_pkts -> tx_error_pkts > > link_signal_mode -> active_fec_signal_mode > > tx_bd_long_hi.mss -> tx_bd_long_hi.kid_or_ts_high_mss > tx_bd_long_hi.hdr_size -> tx_bd_long_hi.kid_or_ts_low_hdr_size > > Signed-off-by: Ajit Khaparde > There are some basic checkpatch errors like spelling mistakes, can you please take care of them: http://mails.dpdk.org/archives/test-report/2020-September/155556.html Also some of the comment are too long, can you please check them too, again above checkpatch link has them listed.