From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB9E642B11; Mon, 15 May 2023 10:17:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90F7F40A84; Mon, 15 May 2023 10:17:43 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2054.outbound.protection.outlook.com [40.107.14.54]) by mails.dpdk.org (Postfix) with ESMTP id B943340395 for ; Mon, 15 May 2023 10:17:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJLnC2cTJlMCojHx0xG2V+DM66da+IfS9uSPkSrlBEaSzo1yWrkCgd/CLLFQ4TZHoIPQg46iXWsIkavUupvdSyKEP4ZOXhfXP5I6FNhk6m1LKuaNEx2FfvFOrV72+YJvUx3R2P8J7FvBcSuoEfv9mtFZxGgLpzuYM1YpPwH3AdrEMA5MyWDh5cHw5FmTWZ0X8PycDhtl+wiZPvIqM/FelwALMLkXUyjRHNi7ru/eh0hNbGwehpiSrCIEeZhKVHaKJJNsuKkhLoWqgdY/yw0Z8FYfrbQyCu2WptPWWcGGfxh3WB+u4Funymt69+FtppQWhF6U6k5Ew0WxTdBWVVt/5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8FeoajBFFVq4mq1acMxu0JwEUT/cVIMVWDCBWBdcPaU=; b=KREluZTT4eL8ImlWKSTMuCrCgO864kJgPHALUCxHDlVB0RmoT7sLwang2bXSQF1UN5EQlfNXvdx5iZ0lwNH2EVc5PAQ1t9v1lTHW1pxH2QIjZIamfTh4w9PaqriwlHcdrmy3E7a/+seLWYtm7n7hV70He5+2YkWhEV6M3wld0sbwMSQAq3M/wlmUrvP9BWpNWWgm5ft6n5JXb0NaA7GZZ6JICSSCDd0dFix8dm6M3Y0lt5kCPjQg+pCD2cFNNV53voC39wgWlOsiVOTzYWpgKEvdvOXOmoZxDtcPuanzOYxDsYK0SaB6mTKd+VCqO1QyHELjdA9pXi6wNTM8bcfOLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8FeoajBFFVq4mq1acMxu0JwEUT/cVIMVWDCBWBdcPaU=; b=RDy9ZwQKTstFWbdmZkDN3jzgdUFsq2UxWuO2htWTadYv11kxC15iyMFivhmMa6DDB96upk/WPqdMJppj3j2fZ99gHBe+34yD796v0dgYDVBGymulMudP3M65LENsBSGabwuGtmyycLeyol5i5MjKlSfx4hLMhHAgti1fgDKEFxs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) by AS8PR04MB8135.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 08:17:40 +0000 Received: from AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::5787:8cca:9d7e:956c]) by AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::5787:8cca:9d7e:956c%5]) with mapi id 15.20.6387.030; Mon, 15 May 2023 08:17:40 +0000 Message-ID: Date: Mon, 15 May 2023 13:46:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] net/dpaa2: change threshold value Content-Language: en-US To: Tianli Lai , dev@dpdk.org Cc: Hemant Agrawal , Sachin Saxena References: <20230508104133.3566-1-laitianli@tom.com> From: "Sachin Saxena (OSS)" Organization: NXP In-Reply-To: <20230508104133.3566-1-laitianli@tom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0044.apcprd02.prod.outlook.com (2603:1096:3:18::32) To AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8562:EE_|AS8PR04MB8135:EE_ X-MS-Office365-Filtering-Correlation-Id: d9309b07-4444-494f-ffb5-08db551cd97f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cHMj845aWkP1HvpNZ60I+NnIoFvonjASUu7asGCi7o459d9FEY5UTEtm7/7AMKr3MhwnugeuQPXlTYCbq2hzsnFu60VhF+9PUxd+02G0BNxWMuRIth14YQv307vrQdWrukY2jX7DjMNFdRGj2cih2jT95pbI8ylB5hocjTOqapmy9rN8H4+nt87JclH+mqdv1WhpJ6pzUpUX5CpkKkD6v6SAqxs9WPwEFOYszIfb1GBBMthtk6Zsz0H9sLY/pJNOzFzSx+UkxitNl8yrwzIcPKbuDhBMPmrf5+nB1IH+YNs/SZHnJUfJN7kO9763TlQ1se4cxPB5hVMbOL9auowIkwgnJiPYKnqKeFpXADyDY9ScAayYiUDEoYnRBJJObgNjeLdPKqdrHSYmFe2pczVOgtcBZwO763Y3DXUf9Cqvu7LXLPr3qUXbpKVoInw9KV3u2gbUcHOjm1IUe78hFd7MpGg/tIO7odRtP6NFeM7YT25zHQAGeGWFnd+ZvwsYBGogkMyfE2f2pHDZDWCHHIXON4GtEquBzgVWK+2DEzO8ikShZblVDSuHeW3fhDcvjGEgdHl11JUbaguFIdIn+S5HA3ZFbdZ0TSG5mvrz/ocCh3NlXVQoTLzTngwsu9Q/tBojYPC9v6e+Idxzol4kqqcbWg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8562.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(396003)(366004)(136003)(376002)(451199021)(31686004)(31696002)(478600001)(66476007)(66556008)(66946007)(36916002)(6666004)(6486002)(54906003)(316002)(4326008)(86362001)(186003)(2616005)(38100700002)(5660300002)(41300700001)(2906002)(6506007)(6512007)(8676002)(8936002)(26005)(53546011)(55236004)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzlhMnRpN2UrdkJDVW8wb3NHNGJBVzhacWhyNEU3QmdLQVhXMnU2ZkZESFlT?= =?utf-8?B?OGJMSWQ1OUdYRFlVMC9Ha0VJczNNYUhpdzM5NkJFOVAxUGdQVko0Q1VzaURX?= =?utf-8?B?ZXYvemxsWkJRVjhYQnlzOGZibE9ISTRiUUsrRXB1LzFmQVFlR0dNVkljQ0o4?= =?utf-8?B?a2ZKcFRjeG42R00wODdoNTh4bUEvNDlZeUpSU1A4eE5oY0g4Sk5kSGdhMG5U?= =?utf-8?B?QjFSRVB0YXM1V21uZVhsQk1kd3QxeXFYaS9VT3JsTVFOMm5IcUxGakdJYUxu?= =?utf-8?B?b0VqN296TTlJQm1HUDJoQVl0bzJJWEhMby9PcGg1bmVaOHl6NjJQdFBHMHpC?= =?utf-8?B?azZRVzZYOHk4OVNmbXNrdmZSa0ZEQVNEL24xcEFmV25qN1lnSzFITnhza29j?= =?utf-8?B?ZUM0K082eFkwU0VXT2lnNGM4K0k4a0x3V0FGaGVkR0o5WlFHbnJrRWh5V05t?= =?utf-8?B?YkZQU0o4d1MrdTQ2VU9hSGpCWjhQRXZmcVR5TEg5MXNvRE1TanJCMWFxYklB?= =?utf-8?B?c0UwNXNDcFo5LzRJdlpaY3RKZHJLVXl1NEtBR3VkZGc5ekMrbXZWWTJDYnMy?= =?utf-8?B?VFI3MXR0UTlEaFhyTGNIbE5kVjRMWDhuRHNiUG0rdGhWZUF1VnVTQ0VMaGFV?= =?utf-8?B?QWtTeDdiSnNNYTVUdWJKaElQcUI4NDNvbkUrd2JuWHkzTVVtOThxYWNsLytB?= =?utf-8?B?Q013YVBsMzJHdlNBWVRmYlpTbytmRVpJRjhrOXVabW9mcHg0bmNXbVZMUEtC?= =?utf-8?B?dEJNOGpJQmEyeXJBV054aVZqZFAySm9wbjdwNlhSQU85VEQxRkdhY25sVld6?= =?utf-8?B?dDlER3Q5TEZxSG5tbFVTS0kzUU9UWVJPcjA1OFJwL09SNG8wY3Q4UTVYTlZ6?= =?utf-8?B?TkExUjd6eWRnbVduZWFKdVNnWGJHaGVNWFJ3R2Rnc3o5SXZqN3ZRNGtTNDBS?= =?utf-8?B?UzZTSnRNZE5CaDgwVG1jRmR0VzJpS0dMc3dLV1RDSGwyU3dxWlFsbk1GcHlk?= =?utf-8?B?ckJnVjB6WTRSZHFMdFZkdmJkdnlveXY5L2hla3ZyNGJYMitwNUdJOThjZ3Yv?= =?utf-8?B?UitPUG5MV090NENXdUZXUW9yU2llZld1UW9vSE5kK1hyelUzNk5BYlUrdlEv?= =?utf-8?B?dS9oN2VRZXZ1a0NwWW5Db082MnRxd3JnY3c0S3NmTnpUQjhvdy9YSDlJcXFS?= =?utf-8?B?T1VWQkdkN1ZEOVVLbGxmWWc4WWlBTlJpaGJhSXZiNktCNmFnc2VYVzBKemE5?= =?utf-8?B?bVE5dkxObEpWSFpvQzliMG81MTVIN1I1ajBJb3lyWTVHM3kwWFlJSlRYS0ZJ?= =?utf-8?B?eDdQMy9BcHZ5eFZxRkNoSnpGMXp2RGVacGdFbE5YTUpuNjkvVFRrREdhYjho?= =?utf-8?B?TWhLbHR6NDNESGJhMEd0WDg1TkcwaVp5cFdqZFFwM3FUMlRrRVF6aFlzZXZm?= =?utf-8?B?T1BPNVcrRWNqSE5nVkxCa3NQcVZMUDlBaHRVbHFUU2ptbkFTS29TYVVSMUdh?= =?utf-8?B?a21Nb2NRZGk5ZEZYYXRLRTV6Zmx4Qmk2WU5YRXA1elI5UDI1WkJkMU0wUmkw?= =?utf-8?B?NWg2MUJwVXR4dXJKa0t3OHpMMDZOSE1ib1lNNVphWVFGVXRudVpJWng5dEVO?= =?utf-8?B?NHl3UG12OWdCTU81a0U4MzlRMHFUNngza3BUOGhaWmsxZkd6KzFoOFFhL0JX?= =?utf-8?B?ODVBUFdWZm5xdDlUYTFxYUVMVkNzTFhHcVE2UXN1bzJlZHErcGc4elVpcUJX?= =?utf-8?B?eFNqTmNQWTlPK2xUdStlNXIwcWJkbkpWaVlIWm5BUlpzelphQXFxYnVNeitt?= =?utf-8?B?a0RLTjlOVUFFK1YyMnZVWkR4cjV4SWNMQ1hnc3RXd2R1c3hyWU1ET0tGNStE?= =?utf-8?B?L0ZKOFFhdGFxVEM1ZmZ3S3NHclJldDZhOTg2ODdRa3VFZklKblRFZktvbld4?= =?utf-8?B?Zm5XTHNvbVhaQ1RheEY5d2krYU90RUpyK0lZQ1pCVEREV1JxRnNpWjc4U0JS?= =?utf-8?B?YkxobVFsZnhRbzZsTjJLWkwvQlhtaEtvbTZpTnluVzdVVzd3cThlMXNDMGtm?= =?utf-8?B?eTNYYWhqV0xEY04wREI1V1JBVFMrZTdMaUVsNmlBZkNaZE9BU2FOc3R1WUcw?= =?utf-8?B?VHRCRDdOY0d6TW9MYklCeXFta09WU0wrbjlkWWEvREswY25nK3lsSXZYM0Jt?= =?utf-8?B?WlE9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9309b07-4444-494f-ffb5-08db551cd97f X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8562.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 08:17:40.5043 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SLQIRSWxlVqtzY1B9TKUiWzZrXQWJactFN90mqvsZjq+Bg76IVZs1iJl6MHQ8xkyjQ/fhB/cbdwuXVk8Eu9gOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8135 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/8/2023 4:11 PM, Tianli Lai wrote: > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > this threshold value can be changed with function argument nb_rx_desc. > > Signed-off-by: Tianli Lai > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index 679f33ae1a..ad892ded4a 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, > dpaa2_q->cgid, &taildrop); > } else { > /*enabling per rx queue congestion control */ > - taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; > + taildrop.threshold = nb_rx_desc * 1024; > taildrop.units = DPNI_CONGESTION_UNIT_BYTES; > taildrop.oal = CONG_RX_OAL; > DPAA2_PMD_DEBUG("Enabling Byte based Drop on queue= %d", > -- > 2.27.0 > Hi Tianli, The number of bytes based tail drop threshold value "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we concluded this value after multiple benchmark experiments in past. Although, number of frame based threshold value is "nb_rx_desc" based only. We will further review this suggestion and get back. -- Thanks, Sachin Saxena (NXP)