From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89FA2A04BA; Mon, 5 Oct 2020 11:53:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBE761B3EF; Mon, 5 Oct 2020 11:53:49 +0200 (CEST) Received: from qrelay149.mxroute.com (qrelay149.mxroute.com [172.82.139.149]) by dpdk.org (Postfix) with ESMTP id 5E8F21B3C8 for ; Mon, 5 Oct 2020 11:53:48 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay149.mxroute.com (ZoneMTA) with ESMTPA id 174f82e61dc0002431.003 for ; Mon, 05 Oct 2020 09:53:43 +0000 X-Zone-Loop: a2967a69f2fc916ae1c443c9507401a54cb6aae6ed17 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 3FFA33EC70; Mon, 5 Oct 2020 09:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:From:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vRmt/iAYpCn0MIvkdZ7kSJn2CTBvlYM33nEp29GYqhg=; b=YdyKBGhILK5zy/7TqQzCeKnVip AKVeCu7dLju5mbA287mTZdtTSyfMqydMrka80TBbhMjmulC76QbeHyRKt95aKSuYYyIVI+NosfojN 5GntmyWcE+LuX2AbcGAFlEP6ZpZxzhH0CiOrDfH4KilRDBBy436CqZMF2W7LjL8jfZgVGjS6gKxuO l809sYgMB98EEKTVrXbCoqDIZVDofmaN6L5pxx2hl+tg2HB5THjnxBilfeQNYeXVCB5zAIPt+J2z+ EGzUXGYUltAIG0RpkiRX/RjNbVtrq+SNUgovoRmtte4k0YxJpsvwGItwD2GuICQgKEGvYSXwwiaar Y+GbECqA==; From: "Kinsella, Ray" To: Gage Eads , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, nhorman@tuxdriver.com, phil.yang@arm.com, honnappa.nagarahalli@arm.com References: <20200528010423.5941-1-gage.eads@intel.com> <20200930213954.15810-1-gage.eads@intel.com> <4d6110f8-fc91-2622-1b10-2cd881f512c6@ashroe.eu> Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Mon, 5 Oct 2020 10:53:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <4d6110f8-fc91-2622-1b10-2cd881f512c6@ashroe.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/10/2020 10:07, Kinsella, Ray wrote: > A nit and some questions below, thanks Ray K. > > On 30/09/2020 22:39, Gage Eads wrote: >> The stack library was first released in 19.05, and its interfaces have been >> stable since their initial introduction. This commit promotes the full >> interface to stable, starting with the 20.11 major version. >> >> Signed-off-by: Gage Eads >> Acked-by: David Marchand >> --- >> doc/guides/rel_notes/release_20_11.rst | 3 +++ >> lib/librte_stack/rte_stack.h | 32 -------------------------------- >> lib/librte_stack/rte_stack_lf.h | 2 -- >> lib/librte_stack/rte_stack_std.h | 3 --- >> lib/librte_stack/rte_stack_version.map | 2 +- >> 5 files changed, 4 insertions(+), 38 deletions(-) > NIT: You are missing the v3 in the subject line, doesn't require a fix. > [SNIP] So after chatting with David, it looks like there is no _nice_ way to indicate that some inlines are "internal" while others are "public". Something to look at in future maybe. >> >> diff --git a/lib/librte_stack/rte_stack_lf.h b/lib/librte_stack/rte_stack_lf.h >> index e67630c27..eb106e64e 100644 >> --- a/lib/librte_stack/rte_stack_lf.h >> +++ b/lib/librte_stack/rte_stack_lf.h >> @@ -27,7 +27,6 @@ >> * @return >> * Actual number of objects enqueued. >> */ >> -__rte_experimental > > This looks like an internal function, should it be __rte_internal? > >> static __rte_always_inline unsigned int >> __rte_stack_lf_push(struct rte_stack *s, >> void * const *obj_table, >> @@ -66,7 +65,6 @@ __rte_stack_lf_push(struct rte_stack *s, >> * @return >> * - Actual number of objects popped. >> */ >> -__rte_experimental > > This looks like an internal function, should it be __rte_internal? > >> static __rte_always_inline unsigned int >> __rte_stack_lf_pop(struct rte_stack *s, void **obj_table, unsigned int n) >> { >> diff --git a/lib/librte_stack/rte_stack_std.h b/lib/librte_stack/rte_stack_std.h >> index 7142cbf8e..ae28add5c 100644 >> --- a/lib/librte_stack/rte_stack_std.h >> +++ b/lib/librte_stack/rte_stack_std.h >> @@ -19,7 +19,6 @@ >> * @return >> * Actual number of objects pushed (either 0 or *n*). >> */ >> -__rte_experimental > > This looks like an internal function, should it be __rte_internal? > >> static __rte_always_inline unsigned int >> __rte_stack_std_push(struct rte_stack *s, void * const *obj_table, >> unsigned int n) >> @@ -59,7 +58,6 @@ __rte_stack_std_push(struct rte_stack *s, void * const *obj_table, >> * @return >> * Actual number of objects popped (either 0 or *n*). >> */ >> -__rte_experimental > > This looks like an internal function, should it be __rte_internal? > >> static __rte_always_inline unsigned int >> __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n) >> { >> @@ -94,7 +92,6 @@ __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n) >> * @return >> * The number of used entries in the stack. >> */ >> -__rte_experimental >> static __rte_always_inline unsigned int >> __rte_stack_std_count(struct rte_stack *s) >> { >> diff --git a/lib/librte_stack/rte_stack_version.map b/lib/librte_stack/rte_stack_version.map >> index 6662679c3..8c4ca0245 100644 >> --- a/lib/librte_stack/rte_stack_version.map >> +++ b/lib/librte_stack/rte_stack_version.map >> @@ -1,4 +1,4 @@ >> -EXPERIMENTAL { >> +DPDK_21 { >> global: >> >> rte_stack_create; >> Acked-by: Ray Kinsella