From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46CDCA0C41; Thu, 16 Sep 2021 17:59:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5893407FF; Thu, 16 Sep 2021 17:59:08 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 227CF4069E for ; Thu, 16 Sep 2021 17:59:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="202093489" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="202093489" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 08:59:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="583703962" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 16 Sep 2021 08:59:04 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 08:59:04 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 08:59:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 08:59:03 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 08:59:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdKh1ilglQJsKTfklpb8p8sDlXCFzmvogmryIwn4bGnHAUXOSym90JTPe8Vdd+EMh0H40uLH4R/XHNq6Kf/piuAOxchfnqyfm8KeSimD44uV68UcyDdNBTUTsQ0J5Z3qEtr5FR8SXdhULxaAc9a+a4JUGh5xLQJQFc30C3VkmFebaGeF9ZvG8uaXYmOiFjju6I0PRFoMUB+q62s6DZOtpyIbrSMHlC5XQDbknU9WsLMQf/STCMUMD9+j4PRg0kKRM9mNXnOQAflK2kEae/FE88j2JqEsUJc3uC9aSQ5rBsI+0tibruYX3clk3bt4c40aZnR7UVDGrVSSESFx/i1cSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=K/9BydEr+aIiEV1i3XtSyX7iNAGLnI2Vdd7/884Y0Lg=; b=j2wFoZ8jqB/YtzAHxkW2go31uMqv94DtfpZUa3ID+Sa9pa+EXaWEXpiJIKl0RGL9VptI9UE/z/dV/PDtI5lAPbKo2rVlSfl/hpyQALi7uOTOjIsjs7wq/Q+hIJfTQSDzqLmNXiIQT8YQFeJ3k6swPODPCG6khua7X+l1Nm/5VrFsXpfgkZWyUJsXyKbcnjplEexTOF5o7jhTbzzgEsRhKmLyBlvciEWgUUxR2OsVwoujGopB4aHUfdzwhCaoiSOMUMG6hf9AeZSgjbiI9yOuSx5sljJE/dGtyQsLoOlQPE9BspkKTPtcB192Lvm4J+Vj+gAwUONG+Hg1TBKJMPO52g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K/9BydEr+aIiEV1i3XtSyX7iNAGLnI2Vdd7/884Y0Lg=; b=WdRcLa5Qmai0YLshUbFRyLa72J1kpb1MvSOvQQQgXnZvUwllq7fzoaFhesfyGVEv2Nk1WBRYO5XsYP6lYNRv1pFB8XoNyiHoaZKwUUx34tIUX97AfuEYTziVv0odEHmkX/STRlzV2DrmMzZMLVL8mb3uiXfu6HEWdkUjkyM6Qvk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 15:59:01 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 15:59:00 +0000 To: Yuying Zhang , , References: <20210906060005.3152399-1-yuying.zhang@intel.com> <20210908045827.3402519-1-yuying.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 16 Sep 2021 16:58:55 +0100 In-Reply-To: <20210908045827.3402519-1-yuying.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB7PR02CA0029.eurprd02.prod.outlook.com (2603:10a6:10:52::42) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR02CA0029.eurprd02.prod.outlook.com (2603:10a6:10:52::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 15:58:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c6faa8e-a1b4-4c07-8ce9-08d9792ae602 X-MS-TrafficTypeDiagnostic: PH0PR11MB4885: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x7RlH8PcztTZKyCenm+a4O+ccCOF/Uw3725nAgB0O2K1vSQVksaEuZVb9yntOzSAt0YPXziu42Y/Ls1TmgN1ZBZ3dIDIkcdVpEAd+me47nOJmm1gS4hkVz52kKbYz54wKLexMRxCvOSuTFlSC2GwV/OClZAIoyXy5beQr6HzRAMu8u3RenYuO1JOLUQ6GD4SiSxxmI5Euim33tUDY0cKStWB+XO71tjCK8mSzpkX9gBEy39pXjIl5yruhkeDnqrmP79zkAJjR8pTFDLN4ZgtbcJ8PJQL96sKCiFXaf04nF6J/myojO0XMfRxbBuqiTjC/2JkhGBW3W6hCeObowtj7weFBCEBp6eUXcq2Ayw6YOCrWcvH0V3Lx8iF4Q+CmefUSA7TykIFkr7zcVzeWwT55lpvdvXAD4ykSMJ71rA82tdx4wFQ0KCtNAoNFSuLNaSOzTDA6i4C+IulJBKT0qPM3n/mcsKp3hrAKTJfRWSOduFIDmntnFOs2XjKuE+9zFjv3AZ2kn+/eatGHqlnHFizT2Bl27gzkfVZU2V8jklogiYIQ98vfyIXw+7Qfd0njKmax5zW648n52YmpRjj5bet6wO9zN1eduIVsNX5tdGWpMFJ5GEzeVds3GYobMIEK5pcOh/iJUnDkqh5zAtflWuEWu1ahT09gU3+oBQN8A4Ou98kx3LSm1qtnifl23xoojO4bHpp6ylTM2rcJI+rQpMCjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(38100700002)(66946007)(86362001)(36756003)(6486002)(5660300002)(83380400001)(44832011)(66476007)(66556008)(2906002)(31686004)(186003)(2616005)(8936002)(8676002)(956004)(31696002)(6666004)(53546011)(478600001)(316002)(16576012)(26005)(6636002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDBtMW5TTkxKZmFvTFpJTGx3Z3lVQkx4QVFpaWpqZGkyTGhRN2dYYkhocmlp?= =?utf-8?B?cEY4Z2tsZDdybVhFMWlLTXN4a0VOWEVJY21uREFBL1F4djhvSU5rVzAwNFNF?= =?utf-8?B?ZThyUWhES1U4QUR4NWxxUnk2VjB2TVdIVDBLRG1oMjNPbnZFMDlGbDY1WnhE?= =?utf-8?B?a0t6dHpndG44UUxYb0pzR0dUemc4aFM2Q0ZhZlZPMVNCb2NMdkR0Wm9rQXcr?= =?utf-8?B?ZW1EN0M1emZkWWNXQ0RJNEpnUEhRcVdYaWdzYk5YRk5jTHhMem1qOHB2K0pN?= =?utf-8?B?V2RFbm9yY0Z1Z1Z6SnZKdjhzUlVXVjFEdk9XOVV1SmZOQVMrVzNCN3FoWk4r?= =?utf-8?B?alNaZWRNdk1EQVNzck1pSU8ydGg5RmVTcisvRnFEcFYraWIyRFV4VUhMS0t3?= =?utf-8?B?MTAwMjF4d1VSWThEcnc5MjVMMGRVTzkvL3NNajVHN1ljVm5ZUWt0U2ljME5x?= =?utf-8?B?SUs1WHE1WGZJSlY2NXRzcEJnU0lNQ0RrMXNEZnNpVDIzbUFFUXg5YVdZdE9Q?= =?utf-8?B?Q0I3QWVFNzdsdzJ0Q3kzenliMEtIMlI2NmxaTXBVc3RQY1Awck8yVk5GbTdL?= =?utf-8?B?MEEycXhkQWNCaVMzMnpYTW9aVlJLelFScmRRVWt1aWM2MDNrMGNZZjVKYlpJ?= =?utf-8?B?NFBRbW9lTERwNkY5SEFRNVBpcTcrSG52SjA5R3A2MGErVnR2THg5QWg4VkM5?= =?utf-8?B?Rk9TRGpsTXN5M0RXL1pKT25GWnBCNDg4T296WjJmU1FDc3BoZkJPNTZJSmpU?= =?utf-8?B?cjNOZVRRUXVtMEltMzI0elRqK25nbytUaFREN0NRR1RmbjNCWDhQc2srR1A2?= =?utf-8?B?OEVSTklqZGxRbDU4aW0wVGdyV2tBbjVHMjYvSGVIVG9SQnZXeVlCd3Q3c0Nm?= =?utf-8?B?a2I5SEVGcUNMU0pQYVRteEI0MHJSM3pPR1FBdzYyb2h4UFMzaXNtT1BwS3hS?= =?utf-8?B?OWtWR2xrZFhlNENQR3ovdkZ6cU1jVUxQNG8rNUF3YVdaWFpoS1RwREhEeDhX?= =?utf-8?B?bCtQR3VyZlFtcDJsZGRKSUlaazQ1REJydUtyRjRFS3ZMTHBpanF3UHIvLzQ0?= =?utf-8?B?cHJCVjJKZmdZdkJyejdLSTBobytIYlpLcno1dDVkSkt3bzY2cWx1SG9vMDJi?= =?utf-8?B?Q2FMNVBrNERwcFhxUG1QV0hFZFlPeCs0SEhPUSswWTJTeEpuQ3hneDUwWnNH?= =?utf-8?B?U25kVEhQeGVpWGZ0TWVzMUZsWHdWRThmaGxubmZrbUVlMUcvRE43ajV0Q1R2?= =?utf-8?B?VGRWK1VCRmJUMEw4UHhac3JHRXdxNGNNRm91OVJDVUhhWGFNN0lqaWJESlFq?= =?utf-8?B?WWc5R1FVaW14ZlJ3eGd4bXorcUdBTDBTeU14cHdTaHE0QjJNNldxSWpPVlV2?= =?utf-8?B?VTJ2cjBVQThUWjEycVRicnZJRjVacmhhdmFveWJLZzlMWWh2aVJJRlcrbWs0?= =?utf-8?B?Yzc1WWZmYmlhcU9pVUhSekpxbHEyY2F1TFg1RnF0TDJIM3dnUnRPSk1qaEZN?= =?utf-8?B?aU5HVnNJVGVuYXpIcm54ZlQ3VVlLSnMrUXdJcEl5WGExNURZQjhWOGtpNlBy?= =?utf-8?B?ZVdnalZuYWJtQnRBQ1pqS2w2ZE04Z1hpcEx1b0FNZHpaMDRoek4vMk9DMWFV?= =?utf-8?B?OUFxTVk3QW1laFppVlJkS1lCZFhmL0tGaUh3dTltOUM5blhrbzh4a0ZTVUwy?= =?utf-8?B?algwSVowOFdWU0oxQS9uTXRVNGJ2MnoxcWQ0cDJDaCsvMkNUT0hUOXRhZHpL?= =?utf-8?Q?G0DPED9q1GDyHPauc1a1Gs2mPMxCDga/KvSjkC4?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6faa8e-a1b4-4c07-8ce9-08d9792ae602 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 15:59:00.7186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AvFrJyKlsPBG9g/YtVhWHBLF+FgqgzTWra+UmR+SJXqqVQOLM2c78AlTO9vkZLbVdz448U6ehGkEY7K2o6Ag9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4885 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/ice: refine flow priority support in PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 5:58 AM, Yuying Zhang wrote: > The usage of priority is converse in pipeline mode and > non-pipeline mode. Refine attribute priority support of flow > filter in PF driver. When priority is 0, rules are created in > switch filter first and FDIR is used as backup. When priority > is 1, rules are all created in switch filter. Other filters > don't support priority 1. Value 0 denotes higher priority. > Hi Yuying, Can you please describe the impact of the change more? Was the usage of the priority wrong either in pipeline or non-pipeline mode previously? If so this is a fix patch and we need fixes line, and consider backporting options. And what is the impact to the user, if we don't have this patch, what user observes? And what is changed for user after this patch? > Signed-off-by: Yuying Zhang > --- > v3: > * Fix priority issue of FDIR in pipeline mode. Refine the priority validation. > v2: > * Replace magic number with marco and add comments to explain the calculation. > --- > drivers/net/ice/ice_acl_filter.c | 5 ++++- > drivers/net/ice/ice_fdir_filter.c | 6 +++++- > drivers/net/ice/ice_generic_flow.c | 4 ++-- > drivers/net/ice/ice_hash.c | 5 ++++- > drivers/net/ice/ice_switch_filter.c | 11 +++++++++-- > 5 files changed, 24 insertions(+), 7 deletions(-) <...>