From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0082.outbound.protection.outlook.com [104.47.40.82]) by dpdk.org (Postfix) with ESMTP id 8F5702BB9 for ; Mon, 19 Dec 2016 06:30:32 +0100 (CET) Received: from CY1PR03CA0031.namprd03.prod.outlook.com (10.174.128.41) by BY2PR0301MB0743.namprd03.prod.outlook.com (10.160.63.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.771.8; Mon, 19 Dec 2016 05:30:31 +0000 Received: from BN1BFFO11FD002.protection.gbl (2a01:111:f400:7c10::1:160) by CY1PR03CA0031.outlook.office365.com (2603:10b6:600::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Mon, 19 Dec 2016 05:30:31 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD002.mail.protection.outlook.com (10.58.144.65) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Mon, 19 Dec 2016 05:30:30 +0000 Received: from [127.0.0.1] ([10.232.133.65]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBJ5UO5m020905; Sun, 18 Dec 2016 22:30:27 -0700 To: Ferruh Yigit , "dev@dpdk.org" References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-10-git-send-email-hemant.agrawal@nxp.com> <4ced5dc6-c2d7-a4d9-b7a1-29476efd9791@intel.com> CC: "thomas.monjalon@6wind.com" , "Richardson, Bruce" , "shreyansh.jain@nxp.com" From: Hemant Agrawal Message-ID: Date: Mon, 19 Dec 2016 11:00:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <4ced5dc6-c2d7-a4d9-b7a1-29476efd9791@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131265990309387933; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39380400002)(39450400003)(39410400002)(39400400002)(39850400002)(39860400002)(39840400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(24454002)(189002)(377454003)(76104003)(199003)(31686004)(23746002)(7126002)(8936002)(65826007)(69596002)(2950100002)(104016004)(6666003)(92566002)(230700001)(64126003)(33646002)(5660300001)(120886001)(626004)(83506001)(85426001)(305945005)(8676002)(81156014)(4326007)(81166006)(68736007)(356003)(2906002)(2501003)(8666005)(4001350100001)(97736004)(5001770100001)(77096006)(54356999)(76176999)(50986999)(31696002)(229853002)(38730400001)(7246003)(189998001)(47776003)(50466002)(86362001)(65806001)(65956001)(106466001)(93886004)(36756003)(105606002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0743; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD002; 1:UBRNXOnKKanjpOoXTiB++MC95GD92+mfzIuI3S7UriIa9tyUVHAwn55L46FlfdLVbbdmmd9cLZaIitWePPWZeC8rfWfDGGDCtI12HxbURQarJj32op0EnBOLUPRDUcJDbetK5lVlQg4hVxniTam+gyDlcG7EA6c13sgi8ivnBHKZIQOmUu8ZYBjvxLoe+ZjD7m82ugcLSaV2u/kXe4fa0e4cuEkZnyyvAdOXKVplPYpdD55ZHxHlf08hso4Xtg+t5yLD6C/0456msqEUcxDNUCVH13MCcOwi2vDT3Sy/PfOGJTOUDCBGtl2QS8gQuYsGLjMajvu6uTR6O+kd7dFvPwfkUwvWArnHx3gE3idOPPTxdUyNRGhSAqTjbw+qCFdQ5RYBvPN2D/P75jaM7jEgehDxlcfcTQMI+CL4FqRh0/TGrW88jO7g74qwwLS10Ew0nrewnccwjxuyVzbVBYCq6yASQxL5Y0MIriLPFdAPtI/QYzxTj9JhX+CwWMe7abQO22k++VdKo2Cu4ZqYbAQ9RnAAdEsaNxRBamvKsAmpxPc3xAnhGLNE3ZnuT0Aw6TQTwGKpwqdmAxfL9OdKST+T/VxPl9XvJxtXFhR2Uoy0b97AxK1obL/eGCy2AWhL/9QGLU3YDD4GP7jG0v6uf6B/j34TsiV94IFmXRgFNOtBSlU= X-MS-Office365-Filtering-Correlation-Id: 27a4c627-552a-4752-5bdb-08d427d025ed X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR0301MB0743; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0743; 3:xMJgmhL7x/Jg00NxFEut0lEU//l/JX4PQn04oYoiFtaA7+wQU5yiUDOudXrRdL52yyw29UVs8vTYnj8v0jtsQ4ssnGK+KpKRndJFSXCDx6UVXec7nwAJlbdm3yh62q0nqzd4J7syAJzj/YhUJKt7LlE/8cn+R3djJbWO6w9fUw0YzvT84HpYD558AjTTQ8Er+om5nbauJfZ5Vmfp4md1Ijh5oE8fpdBtWRaZ6NTER+KNJ+KWhDdkscW0qXLyjRVar25ipc7+WOAyRowOpYPyE54mRw5szuiKKQNXsvkxvLfQAuumza2z3GMOIzu4QwINxepf4WFhkNC+7krxNd1YwTVMWZTEjnPxrzbszra/gsw=; 25:z1Xvp2MhRDwsT3H/WhJWM11gJi09gcyHsAUowo86sROVjd5bSROqsP2CgF7x7LTO0gfqmhCSqMz9puIyKSvOKWESublFlBtJryzrrTEnv+IjUbAjj8bADkiKq1boG+cO2URnHHE8MD+aePP+8688fk18Q9IsjxGGg6fbsZTG+wTJPS99S7HkyKene67jieJlZ2eQurX93X6UPtLq+Rn4Y7roVQnMPZdG8hrzqRrYoaVfQ7B7Xd028HIi031uUC5y0uUHnuzE4ZMVoWch71H3ygemPY7z6eah1UgcUuLfPmwra2B+6iHbw/QqeytoDiLk0lHwlRv4W0IAX1i7mCbBCFDaL2qJeGMMlG4FkVLW/DdvOjR3wtur4LJKKOsHIlc6mUZx+3lyuUNQWLck7Nl1/qigG0zpNzPfo944wC78w2T5zFvnZNbg0rERqdWJJ8YzW/FQ2pcVrkfy1srprvnu9w== X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0743; 31:pILnHG1o89SU4+GwCV1xsX0LSStsuCLxPet+soOpsRWo72opds5dCH9w+gSw9BoeCEExkOSZ2v76VmvcrdMvnTUhXu6e9me3YaevbS0CTPRTOqdO3/9K0wBFX32I2yQ9Xq9ZcUV29WW5KiiRCSX9hLgS4RY30rFHEPskq1rLXC3zxi1SmeRrNlJN2bt2V/y10sMCsesf09k+GGY5fTxMx2qKcKN5+eTTgbCwDPandbAb6DVSTW4cRIiLqkLdJDTHhBSy3cVipx65sInuLD5f5iz2y06iGKPtL5l+yZ4tEGk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(8121501046)(5005006)(13024025)(13017025)(13018025)(13015025)(10201501046)(3002001)(6055026)(6096035)(20161123565025)(20161123556025)(20161123559025)(20161123561025)(20161123563025); SRVR:BY2PR0301MB0743; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0743; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0743; 4:zJMB/JZ6ZWJWBhQnTtz8Ps0CdnJY97ltgxHgg6kTfY9eq4CT39kQYEerhOXhtt+vBAtovIB7VKb3DOGsfLmKLYQAwigjOHXa21S057TYGWlubDgf3lzm/p1XMFKxj4JOWaKTNbV6Su2bP60b8W/tLiA7znSRVv33JOX4y2zCKJJHnAIkvuIH0je22JbYNUkwU6Mp89pRzh+H0oD7igI4rLWCJVNEvGND0eRampgJii0UlgM7oG/pd4ublZsYnKjiVBmQw3NCGxNKvhiP+PWJZihqKkddNlYwbxnyMTOPVR2CmT0M4ft1JoYvp0dsKHr6FnbPiNXJYthpf+5NfbL9UBDsnRUoxkSO0X9WfE2Iy4LJd41Xk3g5noFVcelWlunYTG0dNoeIowEo7ZxB44oPJxftgKzqtmJMtZclvr9O0aapcgF4UrVkuZp6PLsMJxpmAlcLGxfK5oXueaY6WrqKcl2xanJpQNyQGPQHLRNzr1Da242/mjkpU5aZpu6TF/lntTJCCnjattpo3Z1AKwsFKfF9yDrWWHz7wnpFDMA3Vp8tn+b/ax7wcC+5nZF/KfKiDX33/bqHj0CZtKxJupTZkeNy2NbdLDzvcZzFcXX67n5Pq03uGjaIvAgBBNEBF6V551Njs/V1sDdIVv0XJ1R2NmIrSSlofmIaQbIFmey1VijV2BG1NEPnZTANmssekC4bVXbu95HxyEsivwEQRvEn44JPhHjC2/2efEb2akwLJkrSo2ZV3I/PS62OjNWqRCOG X-Forefront-PRVS: 01613DFDC8 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB0743; 23:Xlvjf698WqJiLJq0eXVY0/mkK1CT2Q694ZZ?= =?Windows-1252?Q?txGL652GeEYDeQ1MO7g9vfBi7eyNDX3PULDwrxoj2wIN+OWpa3UbFITb?= =?Windows-1252?Q?+9HRkAnRGvXe819u/mIQtWibVwIluXhD1XBW+chCuduANj/GzrgP9pG/?= =?Windows-1252?Q?+WjqK9XEWGbM0FHMBPvKvOlii+yX40tTqOHqCQckBl9cgw5ob1pyKU7w?= =?Windows-1252?Q?bHaNdwoIqZTZ3MbS0o34DK2e1KOKddAPKAEZHK9c3y3LBHsNf38XeQ6Z?= =?Windows-1252?Q?QUWjXqzxtypjb20aUltiu6RoACZ2Ec7Jh/7kVVZQW4DZP5Q3gXbFsqKk?= =?Windows-1252?Q?1adqigIknX5e6xuLT218pjLwxIwCGDOpBC6Ko9uBl5fz9U/0RP4/1fNA?= =?Windows-1252?Q?vwBDFISqiUlIafCzf253TboDwEfzqbifoORen+m6dFOEM+Rf4Fxzszfe?= =?Windows-1252?Q?0AdY5gNARzNRQhZwfBGgo26e74BWBz3oMgFT0H1t2bamlGSbBNDqecDX?= =?Windows-1252?Q?TU9pRuozpoPxDqgww/w5VtzT68DEp1qnfKL7j1fNG524EzONMSNTjI7S?= =?Windows-1252?Q?geI+ID1s3IhlslXIiqiWV4ZgeKKEDPKCLKZ07zJ5ZB26SwliBuDDi8NG?= =?Windows-1252?Q?EJRZZ2iU5M67HRMFUSJWYzr+2vSEF62hIed1KJMuqt7xGXqgjkD2++Ub?= =?Windows-1252?Q?vCkut61cInqRz2m8xiBhDh5lDjEoYdGgWtnOqnJm7CmsDGkPso/BmRpk?= =?Windows-1252?Q?oquWN6KmTrpACS5jd4n/BbwivH4RAeorLungj6eqGKLgJbvTx41VPufA?= =?Windows-1252?Q?+0h4Orqc404Y1adoQ+WMI5MwiHAZCjihkMVLMM8gVcS/mS4tSYGgdxow?= =?Windows-1252?Q?+6eq3M/P0MDpKUu4okOJaebeSfZ1rUMxtRios/PKN5fcnyvRkHvPIu8J?= =?Windows-1252?Q?Tgwna3zCf8ET/um04pCIpr3NE/pUH+OF4Y2HrC73bppZb1pmds9eR6f2?= =?Windows-1252?Q?NxMw4n/RyzJRcoTVHHDdddVppLLGMkXkLW8xDMuCVr+bBNpF8CvvE0Qn?= =?Windows-1252?Q?XRdba2rLo7KUIMvNutn5JH4yDwqwsbL5nG29N9ieqQrXIY4qJ+7LL3ri?= =?Windows-1252?Q?ZmndCRrygSF5uXXkj2iuEtRiQ5PmT90VcNQxrshwRZ9N5CxftfRann95?= =?Windows-1252?Q?rVSzXNmwrFanJHpM+oeT+pCwzZUkeqxE3fihgyO0QoL3XsSsswXiHWpU?= =?Windows-1252?Q?yRO8U1wz6Fn7xxB+o7bY0BZVLlfSLgBsPGUoXoxXmdl0S9dF8eO+FkzL?= =?Windows-1252?Q?QNetRmWepagnbzc1USyxocLmIEJFecQXYiDAsFeMevUcouf2KNtTulI5?= =?Windows-1252?Q?RDnUF41TCIMs6VG4gtH1cl8m5BwIi5uUgZnnQiMfsJ7N50VpVBaFEP8v?= =?Windows-1252?Q?0fRlVuJqY5eB4kX+o+rxW1xTM+UELH81v8vUS0xNxlwvOW/1czpLEpD8?= =?Windows-1252?Q?OWpG8xKEN6NzknR07naiExBA5OxlwHTGaUAwtkHXR+92rIeeu2YiMbwt?= =?Windows-1252?Q?Ntr+pYaP9mQN25HyGsLo8Afd+jURyTPtgBaqhit+DM06iBIfDPSOcuah?= =?Windows-1252?Q?0YjgDZFXI4zdvimEi16f8H1WWqohd1ucj01Hq12II06ORkKtIKLmXnun?= =?Windows-1252?Q?Veiv7/I5oKluliJhTbCI/W+mG2XlTzQtKqRQPHjhb3kYOT/e6Ok3+608?= =?Windows-1252?Q?sqWcjx2HcEmTWzN4y3+EHj4fMWxU7g6ohY0xzpzaLunC4UyOPb//KxdY?= =?Windows-1252?Q?8l+ar?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0743; 6:okzw3sPZb6Hw950340d40NLv0fHjdoc/rcj57hEgK+1N1PX0zCkPoAgOkPWheZijCyR0rmHyJ/ZRJc9069MgXCv8ACuAIkyXWCwRWQSmUdP5rYJ7CH0l84C6g11Pn4x0oHjoYxZz30x2EZVdNuJJ5300B2U9R+/JOuY+BDTmrK6VXjpNpYBk15hy5aYzUdiftg17fUxdmTOhUaueDNQlAXP12jQRgu3EFZ6fKUhzQL2+H5YSyb4027C4uNAbCbs1LwwjumoULVmfkWRH1ZBlpx8YwdR30OZRcdw8SrSnZgmypdmss/qZe27KrjxpPuGbX/9Vy2kRXBaaf8mM2Rg6ozOyS2aAxatJQAuiOZpRWUuRLEGgA/VlECZ7NGmKgixjpcHsyru6LR5Y9R0NlxgqVVTGHUI+aZgMmBiK5IZJ3GSsTB6NZKUzUxO2i/apVoHo; 5:JjT6TUlFzweoJfEogu8ZZLjqEckH+Wg0fpdFraJALFfZ3ybKda54EtOtqiP6g6YxQNsZYmf57EB4URflaI9g7tBhCzQN6/Ck/A6FrTNCRuS1lKDQMDQxl+VJW2obUHPdhzRnZbtLIpu1N1uuKm8vQbEJlaw1znkyMEB83GhJ9maJIg5EPR3fiwOzIwVw+0ZL; 24:Dn6CO/6lIq11drqSOW9TwZhjtalDsqMxgjiRmnQUanKgn57/l/9/arp2EEw3nSi5c403qWbnezkomMu1/x5llfzOCYvB5BbijKj3gUUwAu0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0743; 7:849Lz+UaDkYBsUYiY2VtmMnXw6QYTqmEpHMOvwIU0YHeovDlQ1JHMk4y6jsn4NSWv/lVQUHWf9uLtsio+z7GJouR/75Q5sm3TpEK0oX3NrnAK0Eizq6HEdiN431X0Xgs7adTAKGFky0RMhxijgdAFDB4kV/ACBi/ndttrB+sCBLgqkfBA4M1AMD+6yBWaszVYJEyJjNx6PsyR2Hp0XGU+wsMEinOI5BY+Ai01SlXGXkH+xfRHfDfwryfMy67tTMvxe7vdW8vszXRdgSc6ocmlca42WjH3Cr1nUX8DYxqvYjyWy1J8Av+UNzP26nMdj7VZ+UpcbA0/MWy3EZNuh6RdqpICUns5cSjooiacovQc9QKg0FJ3xkKe5d6hKy6Ks7hOBJNvT0aBSbqKJp+QrWRtJ+hsCztAwxxhHldjchDEgEm2uBOpsqyNeDjUZmRTDofRP0L7d/6hD75ufnIfQjgiQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2016 05:30:30.6267 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0743 Subject: Re: [dpdk-dev] [PATCH 09/32] lib/ether: add rte_device in rte_eth_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 05:30:33 -0000 On 12/15/2016 8:11 PM, Ferruh Yigit wrote: > On 12/7/2016 6:41 AM, Hemant Agrawal wrote: >> On 12/7/2016 1:18 AM, Ferruh Yigit wrote: >>> On 12/4/2016 6:17 PM, Hemant Agrawal wrote: >>>> Signed-off-by: Hemant Agrawal >>>> --- >>>> lib/librte_ether/rte_ethdev.h | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >>>> index 3c45a1f..6f5673f 100644 >>>> --- a/lib/librte_ether/rte_ethdev.h >>>> +++ b/lib/librte_ether/rte_ethdev.h >>>> @@ -1626,6 +1626,7 @@ struct rte_eth_dev { >>>> eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */ >>>> eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. */ >>>> struct rte_eth_dev_data *data; /**< Pointer to device data */ >>>> + struct rte_device *device; >>> >>> I believe this change should not be part of a PMD patchset. This change >>> is more generic than the PMD. >>> >>> Won't Shreyansh's patch already do this? >> >> I agree that this patch is not a fit for this PMD patchset, Shreyansh's >> patch is not yet doing it. He will be taking care of it next. >> >> So till Shreyansh provide the support, we need it. > > If you need it, what do you think sending this as a separate patch? And > when accepted, your driver can use it? > I will prefer to keep this patch as the first patch in my patchset. If Shreyansh's patch come on time, we can easily remove it. >> >>> >>>> const struct eth_driver *driver;/**< Driver for this device */ >>>> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ >>>> struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ >>>> >>> >>> >> >> > >