From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5D36E6CC7 for ; Thu, 28 Jun 2018 11:41:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2018 02:41:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,282,1526367600"; d="scan'208";a="68002781" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.28]) ([10.237.220.28]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2018 02:41:06 -0700 To: "Zhang, Qi Z" , "thomas@monjalon.net" Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Shelton, Benjamin H" , "Vangati, Narender" References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180628015247.42232-1-qi.z.zhang@intel.com> <20180628015247.42232-7-qi.z.zhang@intel.com> <262dfd01-f580-f313-25d1-467448b7fbc1@intel.com> <039ED4275CED7440929022BC67E7061153240F65@SHSMSX103.ccr.corp.intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 28 Jun 2018 10:41:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <039ED4275CED7440929022BC67E7061153240F65@SHSMSX103.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 06/19] ethdev: support attach private device as first X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 09:41:09 -0000 On 28-Jun-18 10:29 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Burakov, Anatoly >> Sent: Thursday, June 28, 2018 5:25 PM >> To: Zhang, Qi Z ; thomas@monjalon.net >> Cc: Ananyev, Konstantin ; dev@dpdk.org; >> Richardson, Bruce ; Yigit, Ferruh >> ; Shelton, Benjamin H >> ; Vangati, Narender >> >> Subject: Re: [PATCH v6 06/19] ethdev: support attach private device as first >> >> On 28-Jun-18 2:52 AM, Qi Zhang wrote: >>> When attach a private device from secondary as the first one, we need >>> to make sure rte_eth_dev_shared_data is initialized, the patch add >>> necessary IPC for secondary to inform primary to do initialization. >>> >>> Signed-off-by: Qi Zhang >>> --- >> >> Does this mean hotplug is broken before this patch? Can it be moved earlier? > > Basically patch 4,5,6 depends on patch 3, they have no dependency each other. So... is that a yes? :) > >> >> -- >> Thanks, >> Anatoly -- Thanks, Anatoly