From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0537F45FF7; Mon, 6 Jan 2025 03:01:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C571040611; Mon, 6 Jan 2025 03:01:41 +0100 (CET) Received: from lf-2-33.ptr.blmpb.com (lf-2-33.ptr.blmpb.com [101.36.218.33]) by mails.dpdk.org (Postfix) with ESMTP id 761D24014F for ; Mon, 6 Jan 2025 03:01:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2403070942; d=yunsilicon.com; t=1736128889; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=SOBBBrxxqstbLGu+MrkRBIY8gSYxxl8T/vynVey51A4=; b=elAFGEzuaha1dTmhkVYS7QCiCKd258g7X3qYSI8yDf5JMUKO/yTV6FrikhjJwYTwV5rL+4 9nohN4GX94n7L+eKWBN4UOeCLyLyWgdHByrwz4P4akSXscNiS0YaM1RnXjfh0HqIyC/EYX 4GapBku1Dd0QYNIBq58XW3KLV+riWZzOSH9ms6myESzj0vtFoxi7KgS5u7G64XH5lX95Cg yaD7r4uPwjXhQOhYu36sTB5Xiw/9uOjNZeBFelkKWhjYldKlLknJMWu0thODuyZa+LJmXD 1CtB2JsZzwcrvAiV0OROYzW2zlJK5B7lSbxz5YiHGGi8iQymWEgyszKp8Mwn6w== Date: Mon, 6 Jan 2025 10:01:28 +0800 References: <20250103150404.1529663-1-wanry@yunsilicon.com> <20250103150411.1529663-5-wanry@yunsilicon.com> <20250103110446.08fcc408@pi5> To: "Stephen Hemminger" From: "WanRenyong" User-Agent: Mozilla Thunderbird Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20250103110446.08fcc408@pi5> Cc: , , , , , , , , Subject: Re: [PATCH v4 04/15] net/xsc: add xsc dev ops to support VFIO driver Mime-Version: 1.0 Message-Id: X-Original-From: WanRenyong Content-Transfer-Encoding: 7bit X-Lms-Return-Path: Received: from [127.0.0.1] ([116.231.104.97]) by smtp.feishu.cn with ESMTPS; Mon, 06 Jan 2025 10:01:26 +0800 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2025/1/4 3:04, Stephen Hemminger wrote: > On Fri, 03 Jan 2025 23:04:13 +0800 > "WanRenyong" wrote: > >> +static int >> +xsc_vfio_set_mtu(struct xsc_dev *xdev, uint16_t mtu) >> +{ >> + struct xsc_cmd_set_mtu_mbox_in in; >> + struct xsc_cmd_set_mtu_mbox_out out; >> + int ret; >> + >> + memset(&in, 0, sizeof(in)); >> + memset(&out, 0, sizeof(out)); > Optionally, you can initalize on stack variables with: > struct xsc_cmd_set_mtu_mbox_in in = { }; > > Either way is ok, it is up to you. Got it. -- Thanks, WanRenyong