From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0E47C1B6A3
 for <dev@dpdk.org>; Fri,  3 Nov 2017 23:20:46 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga104.jf.intel.com with ESMTP; 03 Nov 2017 15:20:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,339,1505804400"; d="scan'208";a="1239523228"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.48])
 ([10.241.225.48])
 by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2017 15:20:45 -0700
To: Thomas Monjalon <thomas@monjalon.net>,
 "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>, Jingjing Wu
 <jingjing.wu@intel.com>, "Thotton, Shijith" <Shijith.Thotton@cavium.com>,
 Gregory Etelson <gregory@weka.io>, "Patil, Harish"
 <Harish.Patil@cavium.com>, dev@dpdk.org,
 George Prekas <george.prekas@epfl.ch>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
 "Roberts, Lee A." <lee.roberts@hpe.com>
References: <efabcaad-b0e9-e360-22b5-953b0bc20032@intel.com>
 <506f596c-f7e3-56b1-d13a-17b49bc3945a@intel.com>
 <CY4PR0701MB382781A0DF18B5100CCD21109F5D0@CY4PR0701MB3827.namprd07.prod.outlook.com>
 <12814007.65nxXEtm0z@xps>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ec1f6a0c-6a0c-b95e-e830-d1cda4da67ea@intel.com>
Date: Fri, 3 Nov 2017 15:20:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <12814007.65nxXEtm0z@xps>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Nov 2017 22:20:47 -0000

On 11/3/2017 12:24 PM, Thomas Monjalon wrote:
> 03/11/2017 20:18, Mody, Rasesh:
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>>> On 11/2/2017 11:45 AM, Mody, Rasesh wrote:
>>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>>>>> On 11/2/2017 10:34 AM, Mody, Rasesh wrote:
>>>> We are ok as we have at least some way to disable the reset, please send a
>>> patch.
>>>
>>> Sent http://dpdk.org/dev/patchwork/patch/31143/, can you please test?
>>
>> The testing of BNX2X looks OK with this patch. However, the solution has following drawbacks:
>>  - an application will need to be recompiled to have the igb_uio kernel module rebuilt to support bnx2x devices
>>  - this will break pre-compiled solutions that are provided with an OS such as RHOSP or as part of a pre-compiled VNF
>>
>> We can live with this temporary solution for now. In the long term, we may have to revisit this.
>> We are also looking at why bnx2x FLR is taking this long.
> 
> Yes, I think the long term solution should be to fix your PMD
> or your firmware.
> Please keep us posted when you find the root cause with your device.
> Thanks

Lee Roberts suggested doing device specific action instead of build time option.

I send following:
http://dpdk.org/dev/patchwork/patch/31168/

What do you think about this approach?

Meanwhile I will send a more proper patch to discuss on.


Thanks,
ferruh