From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 5A0CE2B97; Tue, 18 Oct 2016 14:49:39 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OF800EDKUAPZQ70@mailout2.w1.samsung.com>; Tue, 18 Oct 2016 13:49:37 +0100 (BST) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20161018124937eucas1p1e161b8062a7a8c24e66eff491a31eda3~_oTUXzPyk2463224632eucas1p1l; Tue, 18 Oct 2016 12:49:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1.samsung.com (EUCPMTA) with SMTP id A8.50.23383.16A16085; Tue, 18 Oct 2016 13:49:37 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161018124936eucas1p294c6fa271c8be7ffcc15cd5506ee13df~_oTTtAjHt2693326933eucas1p2x; Tue, 18 Oct 2016 12:49:36 +0000 (GMT) X-AuditID: cbfec7ef-f79e76d000005b57-56-58061a61efbd Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 9A.6E.07726.E4A16085; Tue, 18 Oct 2016 13:49:18 +0100 (BST) Received: from [106.109.129.180] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OF80061UUAHH090@eusync1.samsung.com>; Tue, 18 Oct 2016 13:49:36 +0100 (BST) To: Jan Blunck Cc: dev@dpdk.org, Declan Doherty , Heetae Ahn , Yuanhan Liu , Eric Kinzie , Bernard Iremonger , stable@dpdk.org From: Ilya Maximets Message-id: Date: Tue, 18 Oct 2016 15:49:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsWy7djPc7qJUmwRBuvXaVtsbhS2ePOgicXi 3aftTBbzTu1lt5j2+Ta7xZX2n+wWrQ9bmSz+dfxht7g+4QKrA6fHrwVLWT12zrrL7rF5hZbH 4j0vmTzmnQz06NuyijGALYrLJiU1J7MstUjfLoErY8mCU+wFH2Uq1j+4ytbA+EGsi5GTQ0LA ROL4/G8sELaYxIV769m6GLk4hASWMUr0PFzGCOF8ZpTY8m8BM0zH3dZWVriqz33HoVpeMEpc Pn0YbJawQLjE7gsLGUFsEQE1iRknIUYxC3xnlJgy+xzYKDYBHYlTq4+AFfEK2EmsWDeXDcRm EVCVeLx6M1ANB4eoQITE7rupECWCEj8m3wObzykQLPF5Rxc7iM0soCnx4sskFghbXmLzmrfM ILskBHaxSxzccIEVZI6EgKzEpgPMEKaLxIknGRDPCEu8Or6FHcKWkejsOMgEYVdLTNzaxg4x poVRYuHEH6wQCXuJUzevMkHs4pOYtG061ExeiY42IYgSD4n/d7dBA8tR4krjB2hgPWSU+HJx H8sERvlZSN6ZheSFWUheWMDIvIpRJLW0ODc9tdhQrzgxt7g0L10vOT93EyMw1Zz+d/z9Dsan zSGHGAU4GJV4eCMusUQIsSaWFVfmHmKU4GBWEuHdJcYWIcSbklhZlVqUH19UmpNafIhRmoNF SZx374Ir4UIC6YklqdmpqQWpRTBZJg5OqQbGLGsu/VXm3WkSvo5r479XKX4vN7Xet/m2ro7C XNaunU9+rZN4Z7puxrud2cpzNvB2+N6/2aR7aapAdi/H/d87um3+137z//by0UTBJ8tdJxf4 PXXID936o8Yg/PfarkfycSuPv51Qc6fR9Xdmwsx1t7n96zfsNZtrXnq+/PWb48seRms/rL7Y qsRSnJFoqMVcVJwIAJJeGIgxAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t/xy7p+UmwRBjfWWFhsbhS2ePOgicXi 3aftTBbzTu1lt5j2+Ta7xZX2n+wWrQ9bmSz+dfxht7g+4QKrA6fHrwVLWT12zrrL7rF5hZbH 4j0vmTzmnQz06NuyijGALcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULXNyRI SaEsMacUyDMyQAMOzgHuwUr6dgluGUsWnGIv+ChTsf7BVbYGxg9iXYycHBICJhJ3W1tZIWwx iQv31rOB2EICSxgl5s5NgLBfMEr8WFsAYgsLhEvsvrCQEcQWEVCTmHFyGZDNBVTzkFFi7cK7 zCAOs8B3Rok1TXPAJrEJ6EicWn0ErINXwE5ixbq5YHEWAVWJx6s3M4PYogIRErdWfYSqEZT4 MfkeC4jNKRAssXj7RKYuRg6goeoSU6bkgoSZBeQlNq95yzyBUWAWko5ZCFWzkFQtYGRexSiS Wlqcm55bbKhXnJhbXJqXrpecn7uJERhz24793LyD8dLG4EOMAhyMSjy8G66wRAixJpYVV+Ye YpTgYFYS4d0lxhYhxJuSWFmVWpQfX1Sak1p8iNEU6IWJzFKiyfnAdJBXEm9oYmhuaWhkbGFh bmSkJM5b8uFKuJBAemJJanZqakFqEUwfEwenVANjtPfX6QGZ5j88lA2jj1/SKBNc8X9z9HGd C1yiF8L8/6lEzDiefvw8U0qxxLz+xHcPd726knSV44it3ArxTbEnCr8Z3Vq+7rYIz2FztVyv PxFmoexqD0J1eMICLRZm3Ky7tO6If02Sv4VP+s7FrOqbf21nMdzzhdfKJfHM3wc6YdNydY5t OsakxFKckWioxVxUnAgAgSAAhM8CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161018124936eucas1p294c6fa271c8be7ffcc15cd5506ee13df X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161018122856eucas1p22493fbd48031126de6093fd312e7a0fc X-RootMTR: 20161018122856eucas1p22493fbd48031126de6093fd312e7a0fc References: <1473251290-22053-1-git-send-email-i.maximets@samsung.com> Subject: Re: [dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 12:49:39 -0000 On 18.10.2016 15:28, Jan Blunck wrote: > If the application already configured queues the PMD should not > silently claim ownership and reset them. > > What exactly is the problem when changing MTU? This works fine from > what I can tell. Following scenario leads to APP PANIC: 1. mempool_1 = rte_mempool_create() 2. rte_eth_rx_queue_setup(bond0, ..., mempool_1); 3. rte_eth_dev_start(bond0); 4. mempool_2 = rte_mempool_create(); 5. rte_eth_dev_stop(bond0); 6. rte_eth_rx_queue_setup(bond0, ..., mempool_2); 7. rte_eth_dev_start(bond0); * RX queues still use 'mempool_1' because reconfiguration doesn't affect them. * 8. rte_mempool_free(mempool_1); 9. On any rx operation we'll get PANIC because of using freed 'mempool_1': PANIC in rte_mempool_get_ops(): assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed You may just start OVS 2.6 with DPDK bonding device and attempt to change MTU via 'mtu_request'. Bug is easily reproducible. Best regards, Ilya Maximets. > > On Wed, Sep 7, 2016 at 2:28 PM, Ilya Maximets wrote: >> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. >> >> It is necessary to reconfigure all queues every time because configuration >> can be changed. >> >> For example, if we're reconfiguring bonding device with new memory pool, >> already configured queues will still use the old one. And if the old >> mempool be freed, application likely will panic in attempt to use >> freed mempool. >> >> This happens when we use the bonding device with OVS 2.6 while MTU >> reconfiguration: >> >> PANIC in rte_mempool_get_ops(): >> assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed >> >> Cc: >> Signed-off-by: Ilya Maximets >> --- >> drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c >> index b20a272..eb5b6d1 100644 >> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >> @@ -1305,8 +1305,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> struct bond_rx_queue *bd_rx_q; >> struct bond_tx_queue *bd_tx_q; >> >> - uint16_t old_nb_tx_queues = slave_eth_dev->data->nb_tx_queues; >> - uint16_t old_nb_rx_queues = slave_eth_dev->data->nb_rx_queues; >> int errval; >> uint16_t q_id; >> >> @@ -1347,9 +1345,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> } >> >> /* Setup Rx Queues */ >> - /* Use existing queues, if any */ >> - for (q_id = old_nb_rx_queues; >> - q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { >> + for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { >> bd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id]; >> >> errval = rte_eth_rx_queue_setup(slave_eth_dev->data->port_id, q_id, >> @@ -1365,9 +1361,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> } >> >> /* Setup Tx Queues */ >> - /* Use existing queues, if any */ >> - for (q_id = old_nb_tx_queues; >> - q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { >> + for (q_id = 0; q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { >> bd_tx_q = (struct bond_tx_queue *)bonded_eth_dev->data->tx_queues[q_id]; >> >> errval = rte_eth_tx_queue_setup(slave_eth_dev->data->port_id, q_id, >> -- >> 2.7.4 >> > > >