From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3D4FA00C5; Tue, 21 Jun 2022 13:24:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75B434069C; Tue, 21 Jun 2022 13:24:52 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2088.outbound.protection.outlook.com [40.107.237.88]) by mails.dpdk.org (Postfix) with ESMTP id A7C7840151; Tue, 21 Jun 2022 13:24:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=duvMpODybeZEykP9BqZ+dgg9S7oiCqaYHspBqxPo+fprHnI+JtKC/oU6i5/JO2dmHQp/P6vzFG3IYDNLdzQN4sLSpsk8dFoyss3cGdz9iWl/6d9pe65PJeP9QdWoMDdYDpSRI05ybCM4ezhmxywGRMv5xkFRZNgew+7VCLLqmsUtmf9T92jBphu6nJw9p1/GdfOMxndWcaunT509UeCEdHRheeIcAPdstfk0niUUBph3WEWbenqCs75RvTyWuuLLjs0CjX+YoqPUJeD4q+XrVkaPAJmbo9cLie6tYLGHTw4om+qPAkn6mFPMCsAJcjECLZ7/VaTqAuyC4PUe0aTFwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+uGN1ABkLB7pc+5oURlRNCVxbd5Wq2dhSuNVEx0bgOY=; b=B+UFpoi0TYksjUHv5Pbl4arVEon7MCOaqlyRx4UWIyy9dhy/jhwNrBIl55b00QzmyGjo70WM/TKWwbQJkhat6JCDRJ/3OtLBJ7euR1n+JKnC3tDMm+1wSsPlRbJLRUyXBwt0+/UcGcREgrhGgamM5vrWYI0iMxPf3GvrC7RUcPEH8UAWBZ6fwdrbn/3ZiYT/VQYPds9UWtmXOvI/ssLu752RyeDR50TKkW+Xp/wNdo1MeOZJXwy3/9TcgBcAqKLs1dRyAGoo/vwWmEy3b090Du0vJQOf3xz68WRWuFqfh2PNxDAn+YQ79MMThaWejcPRVzT17UyZH+u7nlIfU9CCOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=ceng.metu.edu.tr smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uGN1ABkLB7pc+5oURlRNCVxbd5Wq2dhSuNVEx0bgOY=; b=FGgo6lkK7zCfHSdtmxkHoy1fsnDFTMkPYYTxolcdTRrUaQ+5rj66/0gNJnb5+3QdmOjnOFlBGEjwBx0I9NWz30CamPWBq2Be9ArCvkQgQztRBOhzppf2ownJu49OJZ/BAYfhocGtnJ76sdCbXFbkIUDDO379HVJfxdK+eli6CP8= Received: from SA0PR11CA0192.namprd11.prod.outlook.com (2603:10b6:806:1bc::17) by CY4PR02MB2808.namprd02.prod.outlook.com (2603:10b6:903:11a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Tue, 21 Jun 2022 11:24:48 +0000 Received: from SN1NAM02FT0033.eop-nam02.prod.protection.outlook.com (2603:10b6:806:1bc:cafe::b4) by SA0PR11CA0192.outlook.office365.com (2603:10b6:806:1bc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16 via Frontend Transport; Tue, 21 Jun 2022 11:24:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0033.mail.protection.outlook.com (10.97.5.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 11:24:48 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 21 Jun 2022 12:24:46 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 21 Jun 2022 12:24:46 +0100 Envelope-to: omer.yamac@ceng.metu.edu.tr, david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Received: from [10.71.119.54] (port=11731) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o3bzy-0001EK-Nu; Tue, 21 Jun 2022 12:24:46 +0100 Message-ID: Date: Tue, 21 Jun 2022 12:24:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor Content-Language: en-US To: Omer Yamac , "Hunt, David" CC: , , Thomas Monjalon , David Marchand References: <20220620163146.51435-1-omer.yamac@ceng.metu.edu.tr> <338164f32ff2c34fbd2e8c2dae22877e@ceng.metu.edu.tr> From: Ferruh Yigit In-Reply-To: <338164f32ff2c34fbd2e8c2dae22877e@ceng.metu.edu.tr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17258a2b-5d61-4bea-092f-08da5378a6a2 X-MS-TrafficTypeDiagnostic: CY4PR02MB2808:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F7rppmR+/uOylHlMDnOpN7MP8nKCx6hkgWrn/Wj6rCbLAj348uGH+D8GOo6BXCLCXo3+8e2lCuD+VVcu3bul1OSLFi7ZDx+T4P73SRts82E/NqtuvwqNKQ2oNx0zp0yUR1F9Eu+rha7hcle0sWhAYJgs+8AJRizWq0KH2b2yvDT4PvZuCUwAitgJiCVlZwBDfAyRlheCrQ89UCZ63TKtI/GgPSyEViJeot6TegOjdTv4I3O6BK+CyGxjKm9SdL8++gIlpmWaMDGeH0euBVOuuejXo0GTRSeovuxOCRXC0t8BUPUHABMbSBU2jB2ZTFu91lMZ53XWhpRWNuxmaApt+vr4MaNgGmnpHuaQIKG4SgKkOchqQWDmlSlHLw/7Q7AZat/f/1OBnrZJfF2oqL7MkIpqNuLAyAiapadZptc6cYPJTalWpU97aKcZgTAYMbG/ZFIPfeXAXiDtr6JeQKf+Ciyh341soihmij9/u8OfAc63LJRaZSZsNW8/X5ZQexT+mpomUfID3GjuNc9DVWQp3d8dWQPyO9e0YWmoafX8EqlGpr/FlWzlQrKzSSprlUJS/JhXYfD6T8p8cnvJvEKkn97vcgIHqNYMft0/1QZfbm2FKuAV58ai74ar8oGEzYHE/XjYtA35TE58tyb0B0t4T4YSn20ODcEwzMIj5yofjuhUTWFR6c2akdGn90zggdivIMovw64nnR+mr3hG7o/Z7C4rDYULPEjik0EX46lu88S8r6l1naqSgWk6tEB1ZlKaqaaO/oOVBKau58jO0NywNQ== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(136003)(346002)(39860400002)(40470700004)(46966006)(36840700001)(478600001)(186003)(316002)(2616005)(8676002)(4326008)(41300700001)(82310400005)(70586007)(31686004)(70206006)(54906003)(336012)(8936002)(9786002)(47076005)(426003)(40480700001)(5660300002)(44832011)(356005)(40460700003)(82740400003)(26005)(110136005)(53546011)(2906002)(7636003)(31696002)(36756003)(36860700001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 11:24:48.0508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17258a2b-5d61-4bea-092f-08da5378a6a2 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0033.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2808 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/21/2022 12:18 PM, Omer Yamac wrote: > On 21.06.2022 13:26, Ferruh Yigit wrote: >> On 6/21/2022 9:44 AM, Hunt, David wrote: >>> >>> Hi Ferruh, >>> >>> On 20/06/2022 18:10, Ferruh Yigit wrote: >>>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: >>>>> This patch fixes the syntax error when using the single-core >>>>> for both rx and distributor functions. >>>>> >>>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Abdullah Ömer Yamaç >>>> >>>> Acked-by: Ferruh Yigit >>>> >>>> >>>> Can we convert compile time macro to dynamic configuration to prevent >>>> build errors like this? >>> >>> >>> +1 for the dynamic config. Maybe a "-c" on the command line for "combine >>> rx and dist threads"? >>> >> >> Hi Dave, >> >> '-c' sounds good, >> >> Can you, or someone you delegate, address this, or should we create a >> bugzilla to record? >> >> Or Omer if you are interested in doing this change, please let us know. > > Hi Ferruh, > I can do it, if you can review it. Because I am trying to getting > familiar of your coding style. > Cool, thanks. I think main person here who will set the bar for the acceptance is Dave as maintainer of the component :), but sure we all can help/review. >> >>> >>> Tested-by: David Hunt >>> >>>