From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 4B3B99A16
for <dev@dpdk.org>; Tue, 1 Aug 2017 10:13:13 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
01 Aug 2017 01:13:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,305,1498546800"; d="scan'208";a="134420101"
Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.5])
([10.237.221.5])
by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2017 01:13:11 -0700
To: Thomas Monjalon <thomas@monjalon.net>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
References: <20170731023050.28956-1-pablo.de.lara.guarch@intel.com>
<20170731091817.41505-1-pablo.de.lara.guarch@intel.com>
<7230298.g0yYOUbsxP@xps>
Cc: dev@dpdk.org
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Message-ID: <ec4bd956-e079-8d0b-4ab2-41f6ec1b0ce5@intel.com>
Date: Tue, 1 Aug 2017 09:13:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <7230298.g0yYOUbsxP@xps>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Aug 2017 08:13:14 -0000
On 31/07/2017 20:33, Thomas Monjalon wrote:
> 31/07/2017 11:18, Pablo de Lara:
>> When register a crypto driver, a cryptodev driver
>> structure was being allocated, using malloc.
>> Since this call may fail, it is safer to allocate
>> this memory statically in each PMD, so driver registration
>> will never fail.
>>
>> Coverity issue: 158645
>>
>> Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration")
>>
>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>> ---
>>
>> Changes in v2:
>>
>> - Allocate statically the cryptodev driver structure,
>> instead of using malloc, that can potentially fail.
>>
>> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 5 ++++-
>> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 +++++-
>> drivers/crypto/armv8/rte_armv8_pmd.c | 9 ++++++---
>> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 ++++-
>> drivers/crypto/kasumi/rte_kasumi_pmd.c | 5 ++++-
>> drivers/crypto/null/null_crypto_pmd.c | 5 ++++-
>> drivers/crypto/openssl/rte_openssl_pmd.c | 5 ++++-
>> drivers/crypto/qat/rte_qat_cryptodev.c | 7 +++++--
>> drivers/crypto/scheduler/scheduler_pmd.c | 5 ++++-
>> drivers/crypto/snow3g/rte_snow3g_pmd.c | 5 ++++-
>> drivers/crypto/zuc/rte_zuc_pmd.c | 5 ++++-
>> lib/librte_cryptodev/rte_cryptodev.c | 18 +++++------------
>> lib/librte_cryptodev/rte_cryptodev.h | 20 -------------------
>> lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 +++++++++++++++++++++++++++++
>> 14 files changed, 83 insertions(+), 47 deletions(-)
> This is a big change for a small/unlikely issue.
> The main benefit of this patch is an allocation cleanup.
> I think it is better to wait 17.11 cycle to integrate it.
We initially thought of exit given that it is a constructor and if you
fail to allocate memory at this stage, things are likely not going to
work out anyway.
The patch is an API change, do we really want to break again (we are
breaking in this release) next release?
Thanks,
Sergio