From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 5B8C72BA4
 for <dev@dpdk.org>; Mon, 12 Dec 2016 17:25:08 +0100 (CET)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga105.fm.intel.com with ESMTP; 12 Dec 2016 08:25:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,337,1477983600"; d="scan'208";a="41625722"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by fmsmga005.fm.intel.com with ESMTP; 12 Dec 2016 08:25:06 -0800
To: Bernard Iremonger <bernard.iremonger@intel.com>,
 thomas.monjalon@6wind.com, dev@dpdk.org
References: <1481304361-16032-1-git-send-email-bernard.iremonger@intel.com>
 <1481550626-14539-7-git-send-email-bernard.iremonger@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ec5489d2-2c43-9ebd-6db1-ada704a43c38@intel.com>
Date: Mon, 12 Dec 2016 16:25:05 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1481550626-14539-7-git-send-email-bernard.iremonger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public
 function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 16:25:08 -0000

On 12/12/2016 1:50 PM, Bernard Iremonger wrote:
> Replace rte_eth_dev_set_vf_rxmode with rte_pmd_ixgbe_set_vf_rx_mode.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  examples/ethtool/lib/rte_ethtool.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> index a1f91d4..0e539f7 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -1,7 +1,7 @@
>  /*-
>   *   BSD LICENSE
>   *
> - *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> + *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>   *   All rights reserved.
>   *
>   *   Redistribution and use in source and binary forms, with or without
> @@ -36,6 +36,7 @@
>  #include <rte_version.h>
>  #include <rte_ethdev.h>
>  #include <rte_ether.h>
> +#include <rte_pmd_ixgbe.h>
>  #include "rte_ethtool.h"
>  
>  #define PKTPOOL_SIZE 512
> @@ -354,7 +355,7 @@ rte_ethtool_net_set_rx_mode(uint8_t port_id)
>  
>  	/* Set VF vf_rx_mode, VF unsupport status is discard */
>  	for (vf = 0; vf < num_vfs; vf++)
> -		rte_eth_dev_set_vf_rxmode(port_id, vf,
> +		rte_pmd_ixgbe_set_vf_rxmode(port_id, vf,

Will these cause a build error if IXGBE_PMD is not enabled?

>  			ETH_VMDQ_ACCEPT_UNTAG, 0);
>  
>  	/* Enable Rx vlan filter, VF unspport status is discard */
>