From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"tomaszx.kulasek@intel.com" <tomaszx.kulasek@intel.com>
Cc: "Zhang, Jerry" <jerry.zhang@intel.com>,
Wanghanlin <hanlin.wang@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix bond 8023ad mode enable using wrong index
Date: Fri, 15 Dec 2017 12:48:35 -0800 [thread overview]
Message-ID: <ec70dd45-9414-0804-3de7-ac67c6214672@intel.com> (raw)
In-Reply-To: <884f321f-6aac-2bf2-9388-09a5b75f6c50@intel.com>
On 12/12/2017 7:58 AM, Doherty, Declan wrote:
> On 20/11/2017 7:15 AM, Lilijun (Jerry) wrote:
>> Hi all,
>>
>> In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave().
>> I think this variable is only a index for array internals->active_slaves. So its need to be fixed and change i to internals->active_slaves[i].
net/bonding: fix activated slave in 8023ad mode
In the function bond_mode_8023ad_enable(), the var i is used as slave
port id to the function bond_mode_8023ad_activate_slave().
This variable is only a index for array internals->active_slaves.
So its need to be fixed and change i to internals->active_slaves[i].
Fixes: 46fb43683679 ("bond: add mode 4")
Cc: stable@dpdk.org
>>
>>
>> [Patch] net/bonding: fix bond 8023ad mode enable using wrong index.
>> Signed-off-by: Lilijun <jerry.lilijun@huawei.com>
Tested-by: Kyle Larose <klarose@sandvine.com>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-12-15 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 7:15 Lilijun (Jerry)
2017-11-23 16:53 ` Kyle Larose
2017-11-23 22:56 ` Kyle Larose
2017-11-23 22:57 ` Kyle Larose
2017-12-12 15:58 ` Doherty, Declan
2017-12-15 20:48 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec70dd45-9414-0804-3de7-ac67c6214672@intel.com \
--to=ferruh.yigit@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hanlin.wang@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jerry.zhang@intel.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).