From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id B7B3C4B4B
 for <dev@dpdk.org>; Fri, 15 Dec 2017 21:48:38 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 15 Dec 2017 12:48:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,406,1508828400"; d="scan'208";a="12200874"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.53])
 ([10.241.225.53])
 by FMSMGA003.fm.intel.com with ESMTP; 15 Dec 2017 12:48:35 -0800
To: "Doherty, Declan" <declan.doherty@intel.com>,
 "Lilijun (Jerry)" <jerry.lilijun@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "tomaszx.kulasek@intel.com" <tomaszx.kulasek@intel.com>
Cc: "Zhang, Jerry" <jerry.zhang@intel.com>, Wanghanlin <hanlin.wang@huawei.com>
References: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>
 <884f321f-6aac-2bf2-9388-09a5b75f6c50@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ec70dd45-9414-0804-3de7-ac67c6214672@intel.com>
Date: Fri, 15 Dec 2017 12:48:35 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <884f321f-6aac-2bf2-9388-09a5b75f6c50@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix bond 8023ad mode enable
 using wrong index
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Dec 2017 20:48:39 -0000

On 12/12/2017 7:58 AM, Doherty, Declan wrote:
> On 20/11/2017 7:15 AM, Lilijun (Jerry) wrote:
>> Hi all,
>>
>> In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave().
>> I think this variable is only a index for array internals->active_slaves. So its need to be fixed and change i to internals->active_slaves[i].

    net/bonding: fix activated slave in 8023ad mode

    In the function bond_mode_8023ad_enable(), the var i is used as slave
    port id to the function bond_mode_8023ad_activate_slave().

    This variable is only a index for array internals->active_slaves.
    So its need to be fixed and change i to internals->active_slaves[i].

    Fixes: 46fb43683679 ("bond: add mode 4")
    Cc: stable@dpdk.org

>>
>>
>> [Patch] net/bonding: fix bond 8023ad mode enable using wrong index.
>> Signed-off-by: Lilijun <jerry.lilijun@huawei.com>

Tested-by: Kyle Larose <klarose@sandvine.com>

> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-net/master, thanks.