From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B02F4A0543; Tue, 4 Oct 2022 11:04:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A46E740DDC; Tue, 4 Oct 2022 11:04:11 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 1F06340A87 for ; Tue, 4 Oct 2022 11:04:10 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 4DFD25D; Tue, 4 Oct 2022 12:04:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 4DFD25D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664874249; bh=yP1/Z3YH3awRxMswJCeekMxYZlxIcKW5stLLygDxRn4=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=mJtZGM1RC1rfRpaMqLlam56CEjN1yAix9qLomuGMv+dF9/CH2arMxprECjnjmNRg5 gfSOsxmXy7H5idO9jJTkF/k6VMFutsrlQFIVd7eZWmYDZe+W7eBHElIsKGsn2lTDwW je574psaWJ9l6B4qzMfUGBpksRu0TFxjZF+BWsWM= Message-ID: Date: Tue, 4 Oct 2022 12:04:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 1/1] ethdev: support congestion management Content-Language: en-US From: Andrew Rybchenko To: skori@marvell.com, Ferruh Yigit , Thomas Monjalon , Ray Kinsella Cc: dev@dpdk.org, Jerin Jacob References: <20220919121534.1058884-1-skori@marvell.com> <20220929093503.2172344-1-skori@marvell.com> <670f8dc9-75ad-de91-4268-9d7f9dcfb2ef@oktetlabs.ru> Organization: OKTET Labs In-Reply-To: <670f8dc9-75ad-de91-4268-9d7f9dcfb2ef@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/4/22 12:02, Andrew Rybchenko wrote: > On 9/29/22 12:35, skori@marvell.com wrote: >> From: Jerin Jacob >> >> NIC HW controllers often come with congestion management support on >> various HW objects such as Rx queue depth or mempool queue depth. >> >> Also, it can support various modes of operation such as RED >> (Random early discard), WRED etc on those HW objects. >> >> This patch adds a framework to express such modes(enum rte_cman_mode) >> and introduce (enum rte_eth_cman_obj) to enumerate the different >> objects where the modes can operate on. >> >> This patch adds RTE_CMAN_RED mode of operation and > > This patch adds -> Add > >> RTE_ETH_CMAN_OBJ_RX_QUEUE, RTE_ETH_CMAN_OBJ_RX_QUEUE_MEMPOOL object. >> >> Introduced reserved fields in configuration structure > > Introduce > >> backed by rte_eth_cman_config_init() to add new configuration >> parameters without ABI breakage. >> >> Added rte_eth_cman_info_get() API to get the information such as > > Add > >> supported modes and objects. >> >> Added rte_eth_cman_config_init(), rte_eth_cman_config_set() APIs > > Add > >> to configure congestion management on those object with associated mode. >> >> Finally, Added rte_eth_cman_config_get() API to retrieve the > > add > >> applied configuration. >> >> Signed-off-by: Jerin Jacob >> Signed-off-by: Sunil Kumar Kori > > I'll send v4 with few minor correction. Done, but I'm sorry I forgot to specify --in-reply-to.