From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5947BA0C43; Thu, 23 Sep 2021 13:21:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCA1A4128C; Thu, 23 Sep 2021 13:20:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BD55441257 for ; Thu, 23 Sep 2021 13:20:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632396027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cnaTOPezmcv5SHCmeW9LuKHT2cML8jr/CnHtAR1eY7Q=; b=WMFiu8etpWsssKCFGuwMDykdYdT3N5ofeOJvi+UIQjN60ALVGkIcHTzEmFQOkWhZDz5c7S /sB40YUA1k8Qm3r/ihQenD79EtqLp7DaZLnmI+Dq+NHDjLkTYZuAVRIb5YshYCjH7alGJf gRbdeq5gpMOq3bOmi3RHrIT/Cuke+gI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-Gs_oPKHsN9O2GjhzJBPsMQ-1; Thu, 23 Sep 2021 07:20:24 -0400 X-MC-Unique: Gs_oPKHsN9O2GjhzJBPsMQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 21BBB1054FA4; Thu, 23 Sep 2021 11:20:23 +0000 (UTC) Received: from [10.39.208.17] (unknown [10.39.208.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE2EE19724; Thu, 23 Sep 2021 11:20:21 +0000 (UTC) Message-ID: Date: Thu, 23 Sep 2021 13:20:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Andrew Rybchenko , Chenbo Xia Cc: dev@dpdk.org, Ivan Ilchenko , stable@dpdk.org References: <20210818141329.2842686-1-andrew.rybchenko@oktetlabs.ru> <20210915091942.3604998-1-andrew.rybchenko@oktetlabs.ru> <20210915091942.3604998-2-andrew.rybchenko@oktetlabs.ru> From: Maxime Coquelin In-Reply-To: <20210915091942.3604998-2-andrew.rybchenko@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: fix Tx completed mbufs leak on device stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/21 11:19, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Free Tx completed mbufs on device stop. Not completed Tx mbufs cannot be > freed since they are still in use. > > Fixes: c1f86306a02 ("virtio: add new driver") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > --- > v2: > - check vq pointer vs NULL before calling cleanup function > > drivers/net/virtio/virtio_ethdev.c | 31 ++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > Reviewed-by: Maxime Coquelin Thanks, Maxime