* [dpdk-dev] [PATCH v1] net/ixgbe: remove the redundant MAC flag check
@ 2020-11-12 2:00 Haiyue Wang
2020-11-12 23:49 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Haiyue Wang @ 2020-11-12 2:00 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, qi.z.zhang, Haiyue Wang, stable, Jeff Guo,
Wei Zhao, Beilei Xing, Wei Dai, Wenzhuo Lu
The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the
first error message "Not supported by ethertype filter" which is not so
specific, and keep the error message "mac compare is unsupported" which
aligns to the definition of RTE_ETHTYPE_FLAGS_MAC.
Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter")
Cc: stable@dpdk.org
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index dff04c462c..39f6ed73f6 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -870,15 +870,6 @@ ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev,
if (ret)
return ret;
- /* Ixgbe doesn't support MAC address. */
- if (filter->flags & RTE_ETHTYPE_FLAGS_MAC) {
- memset(filter, 0, sizeof(struct rte_eth_ethertype_filter));
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM,
- NULL, "Not supported by ethertype filter");
- return -rte_errno;
- }
-
if (filter->queue >= dev->data->nb_rx_queues) {
memset(filter, 0, sizeof(struct rte_eth_ethertype_filter));
rte_flow_error_set(error, EINVAL,
--
2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/ixgbe: remove the redundant MAC flag check
2020-11-12 2:00 [dpdk-dev] [PATCH v1] net/ixgbe: remove the redundant MAC flag check Haiyue Wang
@ 2020-11-12 23:49 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2020-11-12 23:49 UTC (permalink / raw)
To: Wang, Haiyue, dev
Cc: Yigit, Ferruh, stable, Guo, Jia, Zhao1, Wei, Xing, Beilei,
Wei Dai, Lu, Wenzhuo
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, November 12, 2020 10:00 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org; Guo, Jia
> <jia.guo@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wei Dai <wei.dai@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Subject: [PATCH v1] net/ixgbe: remove the redundant MAC flag check
>
> The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the
> first error message "Not supported by ethertype filter" which is not so specific,
> and keep the error message "mac compare is unsupported" which aligns to the
> definition of RTE_ETHTYPE_FLAGS_MAC.
>
> Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 23:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 2:00 [dpdk-dev] [PATCH v1] net/ixgbe: remove the redundant MAC flag check Haiyue Wang
2020-11-12 23:49 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).