DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] argparse: enable code to be compiled with MSVC compiler
Date: Wed, 13 Nov 2024 08:30:15 +0800	[thread overview]
Message-ID: <ed02e91d-8918-404c-a987-fba164ef90dc@huawei.com> (raw)
In-Reply-To: <1731451713-24543-1-git-send-email-andremue@linux.microsoft.com>

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/11/13 6:48, Andre Muezerie wrote:
> The issues that were preventing argparser from getting compiled with
> MSVC were fixed, so now it should not be excluded from the
> compilation anymore.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  lib/argparse/meson.build | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build
> index 8ab4c408ee..b6a08ca049 100644
> --- a/lib/argparse/meson.build
> +++ b/lib/argparse/meson.build
> @@ -1,12 +1,6 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2024 HiSilicon Limited.
>  
> -if is_ms_compiler
> -    build = false
> -    reason = 'not supported building with Visual Studio Toolset'
> -    subdir_done()
> -endif
> -
>  sources = files('rte_argparse.c')
>  headers = files('rte_argparse.h')
>  


      reply	other threads:[~2024-11-13  0:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 22:48 Andre Muezerie
2024-11-13  0:30 ` fengchengwen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed02e91d-8918-404c-a987-fba164ef90dc@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).