From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D2AEA0350; Thu, 25 Jun 2020 14:46:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A414E07; Thu, 25 Jun 2020 14:46:10 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4A9A023D for ; Thu, 25 Jun 2020 14:46:08 +0200 (CEST) IronPort-SDR: GGr//7UeIvJSiXjfdTXPs92I/D/j2KAMD4lRwYfGzzr7QrdquQNOEZM3Zcp1oW8cAcTZ3n35RQ WTLi4/jqnabA== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="229581050" X-IronPort-AV: E=Sophos;i="5.75,279,1589266800"; d="scan'208";a="229581050" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 05:46:07 -0700 IronPort-SDR: R6k6Ct4FIAjrV0bYcGjle9w4lU6pxYH3p0cbRbzstS5SjOlMbWPrYrH6TWb828YEUz4Mr67rVr YYiUgzDK+3Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,279,1589266800"; d="scan'208";a="452989983" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.30.244]) ([10.252.30.244]) by orsmga005.jf.intel.com with ESMTP; 25 Jun 2020 05:46:05 -0700 To: Louise Kilheeney , dev@dpdk.org Cc: robin.jarry@6wind.com, bruce.richardson@intel.com, Nicolas Chautru References: <20200522132320.26373-1-louise.kilheeney@intel.com> <20200617151051.21191-1-louise.kilheeney@intel.com> <20200617151051.21191-2-louise.kilheeney@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 25 Jun 2020 13:46:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200617151051.21191-2-louise.kilheeney@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/9] app/test-bbdev: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17-Jun-20 4:10 PM, Louise Kilheeney wrote: > Changed script to explicitly use python3 only to avoid > maintaining python 2. > > Cc: Nicolas Chautru > > Signed-off-by: Louise Kilheeney > Acked-by: Nicolas Chautru > --- > app/test-bbdev/test-bbdev.py | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py > index 0194be046..ff2208381 100755 > --- a/app/test-bbdev/test-bbdev.py > +++ b/app/test-bbdev/test-bbdev.py > @@ -1,5 +1,4 @@ > -#!/usr/bin/env python > - > +#!/usr/bin/env python3 > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > @@ -12,7 +11,7 @@ > from threading import Timer > > def kill(process): > - print "ERROR: Test app timed out" > + print("ERROR: Test app timed out") > process.kill() > > if "RTE_SDK" in os.environ: > @@ -66,7 +65,7 @@ def kill(process): > args = parser.parse_args() > > if not os.path.exists(args.testapp_path): > - print "No such file: " + args.testapp_path > + print ("No such file: " + args.testapp_path) Nitpick: don't leave space before parens :) Acked-by: Anatoly Burakov > sys.exit(1) > > params = [args.testapp_path] > -- Thanks, Anatoly