* [dpdk-dev] [PATCH] eal: fix return value comment
@ 2020-06-06 9:17 wangyunjian
2021-02-09 13:51 ` Burakov, Anatoly
0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2020-06-06 9:17 UTC (permalink / raw)
To: dev; +Cc: anatoly.burakov, jerry.lilijun, xudingke, Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
Fix few comments and add detailed comments for return value.
Fixes: 279b581c897d ("vfio: expose functions")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
lib/librte_eal/include/rte_vfio.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/include/rte_vfio.h b/lib/librte_eal/include/rte_vfio.h
index 20ed8c4..15172bf 100644
--- a/lib/librte_eal/include/rte_vfio.h
+++ b/lib/librte_eal/include/rte_vfio.h
@@ -156,7 +156,7 @@ int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
* kernel module name.
*
* @return
- * !0 if true.
+ * 1 if true.
* 0 otherwise.
*/
int rte_vfio_is_enabled(const char *modname);
@@ -168,8 +168,9 @@ int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
* an error on BSD.
*
* @return
- * !0 if true.
- * 0 otherwise.
+ * 1 if true.
+ * 0 if false.
+ * <0 for errors
*/
int rte_vfio_noiommu_is_enabled(void);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix return value comment
2020-06-06 9:17 [dpdk-dev] [PATCH] eal: fix return value comment wangyunjian
@ 2021-02-09 13:51 ` Burakov, Anatoly
2021-03-03 8:44 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Burakov, Anatoly @ 2021-02-09 13:51 UTC (permalink / raw)
To: wangyunjian, dev; +Cc: jerry.lilijun, xudingke, stable
On 06-Jun-20 10:17 AM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Fix few comments and add detailed comments for return value.
>
> Fixes: 279b581c897d ("vfio: expose functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix return value comment
2021-02-09 13:51 ` Burakov, Anatoly
@ 2021-03-03 8:44 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-03-03 8:44 UTC (permalink / raw)
To: wangyunjian; +Cc: Burakov, Anatoly, dev, Lilijun (Jerry), xudingke, dpdk stable
On Tue, Feb 9, 2021 at 2:52 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
> On 06-Jun-20 10:17 AM, wangyunjian wrote:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > Fix few comments and add detailed comments for return value.
> >
> > Fixes: 279b581c897d ("vfio: expose functions")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-03 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-06 9:17 [dpdk-dev] [PATCH] eal: fix return value comment wangyunjian
2021-02-09 13:51 ` Burakov, Anatoly
2021-03-03 8:44 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).