From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <maxime.coquelin@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F14A92C74 for <dev@dpdk.org>; Tue, 14 Mar 2017 13:59:53 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CD48C05AA63; Tue, 14 Mar 2017 12:59:54 +0000 (UTC) Received: from [10.36.116.175] (ovpn-116-175.ams2.redhat.com [10.36.116.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3EFB2D655; Tue, 14 Mar 2017 12:59:52 +0000 (UTC) To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com> <1488534682-3494-17-git-send-email-yuanhan.liu@linux.intel.com> Cc: Harris James R <james.r.harris@intel.com>, Liu Changpeng <changpeng.liu@intel.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <ed42456d-288e-204f-b34e-36efd0991c4d@redhat.com> Date: Tue, 14 Mar 2017 13:59:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1488534682-3494-17-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 14 Mar 2017 12:59:54 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 16/17] vhost: rename header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 14 Mar 2017 12:59:54 -0000 On 03/03/2017 10:51 AM, Yuanhan Liu wrote: > Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio > net specific. > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 9 -- > drivers/net/vhost/rte_eth_vhost.c | 2 +- > drivers/net/vhost/rte_eth_vhost.h | 2 +- > examples/tep_termination/main.c | 2 +- > examples/tep_termination/vxlan_setup.c | 2 +- > examples/vhost/main.c | 2 +- > lib/librte_vhost/Makefile | 2 +- > lib/librte_vhost/rte_vhost.h | 259 +++++++++++++++++++++++++++++++++ > lib/librte_vhost/rte_virtio_net.h | 259 --------------------------------- Did you perform the rename using git mv? > lib/librte_vhost/vhost.c | 2 +- > lib/librte_vhost/vhost.h | 2 +- > lib/librte_vhost/vhost_user.h | 2 +- > lib/librte_vhost/virtio_net.c | 2 +- > 13 files changed, 269 insertions(+), 278 deletions(-) > create mode 100644 lib/librte_vhost/rte_vhost.h > delete mode 100644 lib/librte_vhost/rte_virtio_net.h Other than that, the change looks good to me: Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime