From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: <dev@dpdk.org>, <david.marchand@6wind.com>,
Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/8] eal: define container_of macro
Date: Fri, 9 Dec 2016 13:06:38 +0530 [thread overview]
Message-ID: <ed7d0dc8-b9b9-8524-f72f-b47e3c4501b9@nxp.com> (raw)
In-Reply-To: <df2a131d-dae7-abc9-bbf4-0ae36caafe5e@nxp.com>
On Thursday 08 December 2016 12:31 PM, Shreyansh Jain wrote:
> Hello Jan,
>
> Need your help in resolving the checkpatch issue for this patch.
> I have used this in EAL Bus series [1].
>
> [1] http://dpdk.org/ml/archives/dev/2016-December/051350.html
>
> On Monday 21 November 2016 10:25 PM, Jan Blunck wrote:
>> This macro is based on Jan Viktorin's original patch but also checks the
>> type of the passed pointer against the type of the member.
>>
>> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> [jblunck@infradead.org: add type checking and __extension__]
>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>> ---
>> lib/librte_eal/common/include/rte_common.h | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/lib/librte_eal/common/include/rte_common.h
>> b/lib/librte_eal/common/include/rte_common.h
>> index db5ac91..8dda3e2 100644
>> --- a/lib/librte_eal/common/include/rte_common.h
>> +++ b/lib/librte_eal/common/include/rte_common.h
>> @@ -331,6 +331,26 @@ rte_bsf32(uint32_t v)
>> #define offsetof(TYPE, MEMBER) __builtin_offsetof (TYPE, MEMBER)
>> #endif
>>
>> +/**
>> + * Return pointer to the wrapping struct instance.
>> + *
>> + * Example:
>> + *
>> + * struct wrapper {
>> + * ...
>> + * struct child c;
>> + * ...
>> + * };
>> + *
>> + * struct child *x = obtain(...);
>> + * struct wrapper *w = container_of(x, struct wrapper, c);
>> + */
>> +#ifndef container_of
>> +#define container_of(ptr, type, member) __extension__ ({ \
>> + typeof(((type *)0)->member) *_ptr = (ptr); \
>> + (type *)(((char *)_ptr) - offsetof(type, member)); })
>> +#endif
>
> (I think there was discussion in ML about this but where, I couldn't
> find it).
>
> Above code snippet doesn't go down well with the checkpatch script. It
> reports:
>
> ---->8----
> ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
> parentheses
> #40: FILE: lib/librte_eal/common/include/rte_common.h:349:
> +#define container_of(ptr, type, member) __extension__ ({ \
> + typeof(((type *)0)->member) *_ptr = (ptr); \
> + (type *)(((char *)_ptr) - offsetof(type,
> member)); })
>
> ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
> #41: FILE: lib/librte_eal/common/include/rte_common.h:350:
> + typeof(((type *)0)->member) *_ptr = (ptr); \
> ---->8----
>
> Second error is primarily because of '*<space>_ptr' rather than '*_ptr'.
>
> Is do{ ... }while(0) the fix for the first one?
>
> This:
>
> ---->8----
> #ifndef container_of
> #define container_of(ptr, type, member) do { \
> __extension__ \
> typeof(((type *)0)->member) * _ptr = (ptr); \
> (type *)(((char *)_ptr) - offsetof(type, member));\
> } while (0)
> #endif
> ---->8----
>
> Seems to be ok with checkpatch. Do you see any technical/compiler issue
> with this?
My bad.
obviously a 'do{ .. } while(0)' will not work in case of assignment.
Any other hints as to how to remove this checkpatch issue?
>
>> +
>> #define _RTE_STR(x) #x
>> /** Take a macro value and get a string version of it */
>> #define RTE_STR(x) _RTE_STR(x)
>>
>
> -
> Shreyansh
>
>
>
prev parent reply other threads:[~2016-12-09 7:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 16:55 Jan Blunck
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 2/8] ethdev: Helper to convert to struct rte_pci_device Jan Blunck
2016-11-22 12:46 ` Shreyansh Jain
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 3/8] drivers: Use ETH_DEV_PCI_DEV() helper Jan Blunck
2016-11-22 11:21 ` Shreyansh Jain
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 4/8] virtio: Don't fill dev_info->driver_name Jan Blunck
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 5/8] virtio: Add vtpci_intr_handle() helper to get rte_intr_handle Jan Blunck
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 6/8] virtio: Don't depend on struct rte_eth_dev's pci_dev Jan Blunck
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 7/8] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() Jan Blunck
2016-11-21 16:55 ` [dpdk-dev] [PATCH v2 8/8] ethdev: Decouple interrupt handling from PCI device Jan Blunck
2016-11-22 12:57 ` Shreyansh Jain
2016-12-20 10:51 ` Jan Blunck
2016-12-20 12:45 ` Shreyansh Jain
2016-11-22 10:03 ` [dpdk-dev] [PATCH v2 1/8] eal: define container_of macro Shreyansh Jain
2016-11-22 10:19 ` Thomas Monjalon
2016-11-22 11:26 ` Shreyansh Jain
2016-11-22 12:33 ` Jan Viktorin
2016-11-22 12:36 ` Shreyansh Jain
2016-12-08 7:01 ` Shreyansh Jain
2016-12-09 7:36 ` Shreyansh Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed7d0dc8-b9b9-8524-f72f-b47e3c4501b9@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).