Re: [PATCH v7 01/17] net/r8169: add PMD driver skeleton

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/12/2024 9:57 AM, Howard Wang wrote:
> Meson build infrastructure, r8169_ethdev minimal skeleton,
> header with Realtek NIC device and vendor IDs.
> 
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> ---
>  MAINTAINERS                            |   8 ++
>  doc/guides/nics/features/r8169.ini     |   9 ++
>  doc/guides/nics/index.rst              |   1 +
>  doc/guides/nics/r8169.rst              |  19 ++++
>  doc/guides/rel_notes/release_24_11.rst |   5 +
>  drivers/net/meson.build                |   1 +
>  drivers/net/r8169/meson.build          |   6 +
>  drivers/net/r8169/r8169_compat.h       |  17 +++
>  drivers/net/r8169/r8169_ethdev.c       | 147 +++++++++++++++++++++++++
>  drivers/net/r8169/r8169_ethdev.h       |  28 +++++
>  10 files changed, 241 insertions(+)
>  create mode 100644 doc/guides/nics/features/r8169.ini
>  create mode 100644 doc/guides/nics/r8169.rst
>  create mode 100644 drivers/net/r8169/meson.build
>  create mode 100644 drivers/net/r8169/r8169_compat.h
>  create mode 100644 drivers/net/r8169/r8169_ethdev.c
>  create mode 100644 drivers/net/r8169/r8169_ethdev.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9a812b3632..f68cf48a9d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -995,6 +995,14 @@ F: drivers/net/qede/
>  F: doc/guides/nics/qede.rst
>  F: doc/guides/nics/features/qede*.ini
>  
> +Realtek r8169
> +M: Howard Wang <howard_wang@realsil.com.cn>
> +M: ChunHao Lin <hau@realtek.com>
> +M: Xing Wang <xing_wang@realsil.com.cn>
> +F: drivers/net/r8169
>

Please add trailing '/', like "drivers/net/r8169/", otherwise it breaks
'./devtools/check-maintainers.sh' script.

<...>

> diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst
> index 66b970e036..2393db1e54 100644
> --- a/doc/guides/rel_notes/release_24_11.rst
> +++ b/doc/guides/rel_notes/release_24_11.rst
> @@ -219,6 +219,11 @@ New Features
>  
>    * Added support for DMA queue priority configuration.
>  
> +* **Added Realtek network PMD.**
> +
> +  Added a new network PMD which supports Realtek 2.5 and 5 Gigabit
> +  Ethernet NICs.
> +
>

The expected order of the release notes updates is documented in the
section header, can you please check?
And very briefly, can you please move this just above the 'ZTE zxdh' note?