From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AD88A0524; Tue, 13 Apr 2021 12:25:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB9A0160DF4; Tue, 13 Apr 2021 12:25:12 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 84899160DDB for ; Tue, 13 Apr 2021 12:25:10 +0200 (CEST) IronPort-SDR: 3b6WmaDWth74tJNNTqeEBpKUqG1cwmIKywCnOXD4ARbgsrusGfvUkFjK/E065vP/V72+8RWuSf XZmJeAsIpxbw== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="181508926" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="181508926" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 03:25:07 -0700 IronPort-SDR: nimGC2+c7WM63Yahe4nKSqtQfdYXqJWeRanlTSTZOVOpAp4zZsSmR347M0o/BIkemqRoWd/qvP Nc1Lv2K1RTBA== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="460531487" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.251]) ([10.213.204.251]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 03:25:02 -0700 To: Li Zhang , dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com, cristian.dumitrescu@intel.com, lironh@marvell.com, jerinj@marvell.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com References: <20210331085405.1445546-1-lizh@nvidia.com> <20210413035046.28578-1-lizh@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 13 Apr 2021 11:24:59 +0100 MIME-Version: 1.0 In-Reply-To: <20210413035046.28578-1-lizh@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/13/2021 4:50 AM, Li Zhang wrote: > Currently meter algorithms only supports rate is bytes per second(BPS). > Add packet_mode flag in meter profile parameters data structure. > So that it can meter traffic by packet per second. > > When packet_mode is 0, the profile rates and bucket sizes are > specified in bytes per second and bytes > when packet_mode is not 0, the profile rates and bucket sizes are > specified in packets and packets per second. > > Add the necessary checks to the existing drivers implementing > the rte_mtr API to makes sure that profiles with > packet_mode set to TRUE are rejected. > > RFC ("adds support PPS(packet per second) on meter") > https://patchwork.dpdk.org/project/dpdk/patch/20210125012023.1769769-2-lizh@nvidia.com/ > > Depends-on: series=16301 ("Support meter policy API ") > https://patchwork.dpdk.org/project/dpdk/list/?series=16301 > Hi Li, I am not clear with the dependency chain, can you please clarify, 1) Is this set depends to series-16301? Because it compiles fine after conflict resolved, I can see in your repo there is an order, but if there is no functional/logical dependency you can set this patch exactly on top of HEAD (removing the series-16301 in between), so the CI will be enabled. 2) According its cover letter series-16301 depends on mlx ASO patch, this makes all ethdev patches dependent to mlx5 set, I guess that is wrong, can you please confirm? Above (1) is more important, since series-16301 not fully acked, it is blocking me to proceed. > V2: create a unified patch that contains both the series with > the API changes and the series with the necessary error checks in the drivers. > V3: Fix comments about commit-log. > V4: Fix comments about Depends-on and rebase. > > Li Zhang (4): > ethdev: add packet mode in meter profile structure > app/testpmd: add meter profile packet mode option > net/softnic: check meter packet mode > net/mvpp2: check meter packet mode > > app/test-pmd/cmdline_mtr.c | 40 ++++++++- > doc/guides/rel_notes/release_21_05.rst | 12 +++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 31 +++---- > drivers/net/mvpp2/mrvl_mtr.c | 6 ++ > drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++ > lib/librte_ethdev/rte_mtr.h | 90 ++++++++++++++++++--- > 6 files changed, 159 insertions(+), 28 deletions(-) >