From: "Hunt, David" <david.hunt@intel.com>
To: Mordechay Haimovsky <motih@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"radu.nicolau@intel.com" <radu.nicolau@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix prog exit on ini pwr lib
Date: Wed, 7 Nov 2018 14:21:21 +0000 [thread overview]
Message-ID: <edc2ea7f-e14a-1610-6f5e-2b113c6297ec@intel.com> (raw)
In-Reply-To: <1541599750-18432-1-git-send-email-motih@mellanox.com>
Hi Mordechay,
On 7/11/2018 2:09 PM, Mordechay Haimovsky wrote:
> This patch replaces the rte_exit routine with error printing when
> init_power_library() fails and by that restores the previous behavior
> of the program (which was to issue an error message and continue
> working if init_power_library fails). This allows the user to still
> experience the Rx interrupts feature of the DPDK demonstrated in
> this program.
>
> Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options")
> Cc: radu.nicolau@intel.com
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> examples/l3fwd-power/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index 0b3f8fe..9c7b315 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -1957,7 +1957,7 @@ static int check_ptype(uint16_t portid)
> rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
>
> if (init_power_library())
> - rte_exit(EXIT_FAILURE, "init_power_library failed\n");
> + RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n");
>
> if (update_lcore_params() < 0)
> rte_exit(EXIT_FAILURE, "update_lcore_params failed\n");
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2018-11-07 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 14:09 Mordechay Haimovsky
2018-11-07 14:21 ` Hunt, David [this message]
2018-11-14 3:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edc2ea7f-e14a-1610-6f5e-2b113c6297ec@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).