From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 922C034F3 for ; Wed, 7 Nov 2018 15:21:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 06:21:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,475,1534834800"; d="scan'208";a="87383557" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.115]) ([10.237.221.115]) by orsmga007.jf.intel.com with ESMTP; 07 Nov 2018 06:21:22 -0800 To: Mordechay Haimovsky Cc: "dev@dpdk.org" , "radu.nicolau@intel.com" References: <1541599750-18432-1-git-send-email-motih@mellanox.com> From: "Hunt, David" Message-ID: Date: Wed, 7 Nov 2018 14:21:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1541599750-18432-1-git-send-email-motih@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix prog exit on ini pwr lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 14:21:25 -0000 Hi Mordechay, On 7/11/2018 2:09 PM, Mordechay Haimovsky wrote: > This patch replaces the rte_exit routine with error printing when > init_power_library() fails and by that restores the previous behavior > of the program (which was to issue an error message and continue > working if init_power_library fails). This allows the user to still > experience the Rx interrupts feature of the DPDK demonstrated in > this program. > > Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") > Cc: radu.nicolau@intel.com > > Signed-off-by: Moti Haimovsky > --- > examples/l3fwd-power/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index 0b3f8fe..9c7b315 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -1957,7 +1957,7 @@ static int check_ptype(uint16_t portid) > rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); > > if (init_power_library()) > - rte_exit(EXIT_FAILURE, "init_power_library failed\n"); > + RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n"); > > if (update_lcore_params() < 0) > rte_exit(EXIT_FAILURE, "update_lcore_params failed\n"); Acked-by: David Hunt