From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A166CA04FD;
	Wed,  8 Jun 2022 13:19:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9206940689;
	Wed,  8 Jun 2022 13:19:08 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 57D484021D
 for <dev@dpdk.org>; Wed,  8 Jun 2022 13:19:07 +0200 (CEST)
Received: from [192.168.1.40] (unknown [188.170.81.145])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C65AA2FF;
 Wed,  8 Jun 2022 14:19:06 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C65AA2FF
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1654687146;
 bh=1fqIHe9WagzU+FPHPshBkeK2RjwfbCnlAjjMtxriy+4=;
 h=Date:Subject:To:References:From:In-Reply-To:From;
 b=pkSyWgQq9dbcWKMnyzgzohCoY67fQZPGiLTZJfiwnW2MOZ1Cke5f7J//Is6bv1CS+
 Wy8JFkEOZ64RtcqR7kSGGQMIJdOh8lSUy0lEnQpwBUTq2LokN+fKsSlrO0eI/I4l57
 zOaw1l+ImnU7+UmwbBMn9mXCyQrVpq4qcnW2JwyU=
Message-ID: <edd2061a-077a-9a4a-18eb-67a8cdcf0c4c@oktetlabs.ru>
Date: Wed, 8 Jun 2022 14:19:05 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 06/11] net/hns3: fix coverity codecheck
Content-Language: en-US
To: Dongdong Liu <liudongdong3@huawei.com>,
 "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
References: <20220519122917.2334-1-humin29@huawei.com>
 <20220601035251.16408-1-humin29@huawei.com>
 <20220601035251.16408-7-humin29@huawei.com>
 <8746557a-44c6-bde4-ee96-c73a921c1d9b@oktetlabs.ru>
 <c9e8f9c0-fbef-501c-f374-a7f48c320bea@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <c9e8f9c0-fbef-501c-f374-a7f48c320bea@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Dongdong,

On 6/6/22 10:48, Dongdong Liu wrote:
> Hi Andrew
> 
> Many thanks for your review.
> 
> I will take over Hu Min's current work and continue to do the upstream 
> work.
> 
> On 2022/6/1 16:32, Andrew Rybchenko wrote:
>> On 6/1/22 06:52, Min Hu (Connor) wrote:
>>> In bitwise operation, "val" should be an unsigned type. This patch
>>> fixed it.
>>>
>>> Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP")
>>> Cc: stable@dpdk.org
>>
>> Please, let me know coverity ID. No necessity to resend.
>> I'll add it on applying.
> 
> The code warning is checked by our internal code check tool,
> does not have the coverity ID.

Hm, the summary says coverity. Could you suggest how to rephrase it.

Thanks,
Andrew.