From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id B97C42BAA for ; Fri, 24 Feb 2017 10:14:18 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id r141so9630169wmg.1 for ; Fri, 24 Feb 2017 01:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nHjNy3q+4g4y46DQUNZLG2BI0T2+qqYTgRCNP60DkMU=; b=vG1b52LHsIdA+TaAmtS6PiKfZWLYoBpPlyonOAyUS86AY/hR/Y7CAQ4qqIOdjUgIyA 0X0kn58jOBqKrwNOJ5XAqFYMrXUvEUv7+9CAhqiqmtee6puRsEilYiwa1y8GykvpQGjE tPFG4XEwYlQxgky2M9K74kLKfvBVGooOnminXFOyQ0itzhRW/GuebVd1wXsRcIDDQevx mszHHRtol6r564x1GCmqP6TlhQSh9ZScVQn+SyVUXEKvXsTO0dNV+lpG5VSDARv8X8Is O5QomyXtyTfJ86oD0GoIChvIE2PUYwJbwITGrQjCd7iUPoZYtvmh6OQQIo7Dvm8PlV2z 7cFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=nHjNy3q+4g4y46DQUNZLG2BI0T2+qqYTgRCNP60DkMU=; b=pNqASGFTvFnhVEuAvWywSUWNy7gpYi4G5p24JGoGANd8MXvOQqsZkOZyGFC5Cbnbdv RUwGS+j8OjlcLDB/7LrxdzUWncg0cOz6VBdPQ9SltiBIjIle181C4MEB/Nf7Zfq/ZAOG tKzFFBx/RTkWFvRM7Mgrp+FwhQtMk0TcEYsE9TNKnNxnV7O7F9HXJ4LVs1PgnYLvOAWK lPvxoZM1cskoZ6SQykCGlR5AeYb0K5rI9uXtNOWwdGGjN5MSJKbQgHWi3in5ixOdIQZQ fZy5EhcqPvVwBK/+TNeJ6Cr5WZ+NBtjIxm30L16Ey50ZtXhY0FIvmQ11fQ/8+jE3wRJF EkBg== X-Gm-Message-State: AMke39l/mzDPkqcjz/LTFbvgP8H00Xdx9jCmrwf6xXBduP7+HrKu4LxclAD1Gj1LjKf9JIv2 X-Received: by 10.28.97.194 with SMTP id v185mr1684843wmb.117.1487927657845; Fri, 24 Feb 2017 01:14:17 -0800 (PST) Received: from [192.168.192.189] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h75sm9527592wrh.37.2017.02.24.01.14.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2017 01:14:17 -0800 (PST) To: "Lu, Wenzhuo" , Stephen Hemminger References: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com> <20170223225507.69ee0e47@xeon-e3> <6A0DE07E22DDAD4C9103DF62FEBC09093B5682B7@shsmsx102.ccr.corp.intel.com> Cc: "dev@dpdk.org" From: Vincent JARDIN Organization: www.6wind.com Message-ID: Date: Fri, 24 Feb 2017 10:14:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5682B7@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 09:14:18 -0000 Le 24/02/2017 à 08:23, Lu, Wenzhuo a écrit : >> It is good to allow setting QoS on device, but it looks like this is a device >> specific API, not a generic PMD function. I don't think any feature in DPDK >> should be hardcoded to one device type. > Yes, they're private APIs. > Normally we want to support kernel PF + dpdk VF. As there's no PF - VF interface defined for QoS, These features cannot be implemented on VF now. > Have to put them on PF, and let PF play as a controller. > There's discussion about if we should rich PF host features. So, I put these functions to rte_pmd_i40e.h to show they're experimental and temporary features. > > There's another thread started by Cristian for a generic QoS solution. After it's accepted and the PF-VF interfaces are defined by kernel driver. We can use a generic solution to replace this one. Same, DPDK continues to diverge from the Linux kernel for PF capabilities. Intel did commit previously that you'll do some works for proper PF support into the kernel to avoid it. It is not happening. So, I would rather keep nack'ing such series unless: - either it is under experimental compilation option - either it is showing up into the kernel Best regards, Vincent