From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32EF9A00C5; Tue, 15 Feb 2022 12:25:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B824B410F3; Tue, 15 Feb 2022 12:25:55 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 44E5340E78 for ; Tue, 15 Feb 2022 12:25:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644924353; x=1676460353; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=aP2UamMdBhdVrALHzBMSdXz52JWNyFIAYVJGl3FKJFw=; b=dC+kS/z2Tl+xSz+JQpInGw9YLVOLc5XGY/2wSNDyfK8iCaYkKbj4UuSY ww/g6A3McdGnc5GyrbXy8TNrQSNtflPQC9MpwJQCbl8aiULWFBfVwR9Ef 9q2x7nirh6fIefy6znypJfbO7Meg+5Xn08O9I20iTTJQBhGbSDZ6lVbbo NV+da61d5265ztrEWKXtUKKjm2TeCBespma+KN2XJwq9d05Q8HEVJ9kNZ RMUljWessKO5DgeoSW5KON8vnU7BwlCa99lVtDH4KbyLDDs4KOyNbyZMm 81minwqK1/9r1h69yOqaPr3j4sdjt90axENTnbVsyi37blN77DdMtShqc g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230959205" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="230959205" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 03:25:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="703608213" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 15 Feb 2022 03:25:51 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 03:25:51 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 03:25:51 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 03:25:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNMjHq8DhKSWCQ4iZs1OcqaOf0MMSr2RW5JR9PYk9rUlNj21pNk51Z2B25rpsNJArGl61tP25izzxaemqg1xFN21thdxxoOOHrpWXqTTPBvRwarW6lmM4R8UghCotVCVBvEuYd4JNsCsZLxtBMEy1Lim25D9ogEVNI/MNvrdAD7LPFFUIsLPKS86d2f2fu9kctaBPUe/mnTvNeKjfYgWjBNnuRLOWvgQGRBi90iHoaxZYLRUTzVYuCKHVlILo6bwhE+pgyUzjsKwLojUgYHSE3rYuyNktgYbUj0RImMz+RQkdw6ylPC4IPfKCahknBWBKj95g/5Q/F42LLVYGf3jmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSVptkwou4OtQ32R+hByCbqu6DemelNjDM2xU/Py5hE=; b=lX0PmCQOHXbsWi4JWFBnHg3HXkPl+8mZ4sfRi0TYUCZJ5jIYw+eQhuVt21XXQ3aoKaHri26+6uEl81VEjrkOQh+8713IkEW42ojrGMXpVjNgzg43fHdQg/vw1HM9trOu3pqLsl2UTGHTVS5iYATnbsnmD48YfaWRGGjPRVhk8a+9giXd8tTyScfmdLU5UiG7WjICI5ykqKw3wUEa0oWi3m8UwC+jwq+VEmurUo2LAFR4RE5zc9O5jvUFJRK8Z9vQMw+reUJ39hCumL0xPQjT9v11YOC68orNhwf3qlsSiQTRrUjrkI3PletgSWF33SNKKB1GsFYkR2vtQJ6/dSZOSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4920.namprd11.prod.outlook.com (2603:10b6:510:41::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 11:25:47 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 11:25:47 +0000 Message-ID: Date: Tue, 15 Feb 2022 11:25:41 +0000 Content-Language: en-US To: Kevin Traynor , Radu Nicolau , Jingjing Wu , Beilei Xing CC: , , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0296.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38fab68d-0563-45f0-f79f-08d9f075e9d8 X-MS-TrafficTypeDiagnostic: PH0PR11MB4920:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tUOcf1g/Pb2jrKiZB72rk3VMDmh1tMBOK1AjZW6n/Wob5OSw6GJncgD7R/fsUU9XEY5SK2nA4Vt6lQPOUkr8klGmKJP8a8Ocb1MHVqatw6KX6ZMucTOs+/Inkr9XBuyLpC3h5H+bngHWC1xnyNOcBClf/0+hNksYLOkL53CTB+68+asO91EJVLpb9kHqOYIHF5RxRxPRyPeYmaUeyeqR/J5POQkvylzroPTX0adISk3zM4YH2Klkuy9cg9C9VoshQBLYIukt65Hh/C+IUb7ZtSythOP6Zg1mw9SsSvf7qMgKz9Go73hQQFZWtOuOU4LjFzsQaYqy9OfMdmkLGUYSaoVWQSThIOTyRF+y4A+WsUe1yExf6wnoerpS1lWTUhweNr3MM+7udjc9Pq8kEXt4pQvWk3FQkfhu51y+BUJhZphmmuOWrhSU9GJQYj/1748LME12R8cE5V7cncBe6L0O5Q+4GEfFZPFArKMwl8uAhWmkOnrLqHbpRMeUf34LnzDZ6thCh3ZXkHrlQDFd6lDAQjH1ZcmLh1As8s/r+aIKql18qFkWIWP9W/uUAEn8KM5PKw0HiUaiEuZLCzoOLNcgRR0bXQ5/p1NB1is6r7MKakpbWmPRFfS2vbnfWfZgMDuVPWhjMvH49pY803AbUYgmNTkk6yGt3Q9zKaDyP4BTecLLA6JIdNe8g0UhElBG3Pf2wdvlP5HUAqADeafMoXFu3A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(6512007)(82960400001)(66476007)(83380400001)(5660300002)(6486002)(66556008)(186003)(508600001)(4326008)(44832011)(8676002)(66946007)(26005)(53546011)(316002)(38100700002)(6506007)(31686004)(31696002)(6636002)(36756003)(8936002)(6666004)(86362001)(2616005)(110136005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHBMTk5PV1lISk45ZWswRGExeWV2c2Irc25NOHpVQ3pTVHVhR1JVNnM3NWhl?= =?utf-8?B?d2ZIUWdMWUNUWmpSckhrckNIaFN1alh2amthQnAyTnlRTUpCWlNTV0lqaVlU?= =?utf-8?B?ZVFFLzI1SmJmeWhGM2pockY4b0dnMlArcDNHSkdZUlZkTW5ocVliWjloTDRU?= =?utf-8?B?Qnd6K3FpcnJ0d2lTa0JYNXB5NW1rUVlHSHRWeExUQksyU3dUbUttVjZUOVhD?= =?utf-8?B?WFB4UVZzcWpMR3hhWkZaRUdDelh5YmdYSm5yeFdScmpKQkdSczk4VTg2ZUJu?= =?utf-8?B?ZXZvMWdaV1dOZ0szTWRIYjY4aG1UelIyZXJFVkxPajcrTzZXT09iSE5RdFdj?= =?utf-8?B?endiMm1oOGljRlJJcjdmYjNaSGFWSERoT0ZkKzc4QkRVSUkzclJjdkdoRFdX?= =?utf-8?B?bmhsS0JqcmdJOVdQeWwzV2VNK0M4K1BlSDd6WlBzazRHa1pxV1cvL1YxN2Fn?= =?utf-8?B?YXQ4OEtHbTYwSlY2aWdLWGt5L2lFcnNseHlHT0JOTHZVTXkyckhKcjdaUDgw?= =?utf-8?B?UkRTMzdPNzFoUnJpbVlTcUJ2T1VEQkhvZ3lyZjRROXZ6cVdsZndHa1pRWHE1?= =?utf-8?B?b0JKUElsNGd3SzRpYzczeGxkc3ZVSXIrVXF0cE1VTkN3cVhZdXBTQmExeFox?= =?utf-8?B?cjJRbW1PRnVzcURCUFFSdjFaUVFJbTBZcVliQ1FTUE9LSG9rVzNjMDcrbGgy?= =?utf-8?B?dzJWTm1aOUZCMStDcCtqNzRERGNTTTluN0hmMFlUWWZId0dxUlg2VkYyZmdz?= =?utf-8?B?VjNsYnRvMW8vd3h1SExxMWpHZ3p6Sno3a0tJdFhXQkdIQ1l4MDhxUTIwUGUz?= =?utf-8?B?R1FLWm5tY2tuRGZ5QmR4S1RZcWM1SjNEbHR0Y2lDU1JZei9WV0Q3a21HSDEv?= =?utf-8?B?cTRFRjIzdm5EaHdYZWZBdFF6ZHFFaG5BU2FUYUs2Z3NkckRoWFRNdWZIOUlk?= =?utf-8?B?MXdwN1d6OERlZWlreEQybGNGYzZaSVpsZngyMzh4bUJ5VVBmZTNqbXFIczVk?= =?utf-8?B?b1hXOE1vZFByUExibjIvbW1SaThweTEwSzM5cnlvdmpCRC9LNGNlUU01OWl3?= =?utf-8?B?VFhIRFFKbWVGQWx1TzVHb0JCK3M1dnhvaEZrWmNtZjJWcWxocmdqYi8yQmI0?= =?utf-8?B?MkNaU000RFZwSDVjbUVBTE52c2tHd0NNR0VGdjQrZU0xWXV1b1c4SWRraGkx?= =?utf-8?B?ZWVHeUN3WmNnRGMxbDFaVDNYTjIzR2U1UkJZbVYvbVNpd3FaVUdjZlVyLzJs?= =?utf-8?B?eWppa25HRWt6MU9abmgzL0dMOUUySGE5WW11cUtsVzNqcWFiQkVSQ1IxbXNr?= =?utf-8?B?dzF1SkEvWlpuazEyV3AvOWxmTEF6Rmp3amlBdWxyNU1vR1ZrcC9OVlM5ZVZa?= =?utf-8?B?Q1lPeU5TRUZaNEZqZjNMekU2Rm1lY09GaDhxZ2NPOWd0a2tSSW8vc1pnU2xB?= =?utf-8?B?TkJiNnUzWXFidWdhbUE4K2JDbTFYand4L2VwYTNMZ2xhc2gvTTU2T2tkeTg2?= =?utf-8?B?R2JVZGNDYzdaeDRsVWRDMlh6d0VsZmZEZ3RMaXcwLzl0Tm4xelhkRUM4TWRv?= =?utf-8?B?b1BJRVl5dURpc3g5RTcyeU9YdEU3RzRFTmZ5dzNEYzY3SExPeW9QM0hwc1dS?= =?utf-8?B?Z3JQLzdSY2JySGtPUGhFRUpnVHYvWmNRMDhBbkpQZlpYampuWlNEMlRkSUNn?= =?utf-8?B?TTM3WFAwUjU5enVOVjgxYnRWcXJkTmVPcnpDTk9ZOGNuR3FXV2JrWG5MMFVi?= =?utf-8?B?OHJkcGYwMUs0alBJeHIrUzcvdWRGQ2tvUW9SK2k1c1hFTmVWSlFCbS9HTndr?= =?utf-8?B?N3RkbnNBSDk1VmlQUjVrWGNJbnhIZkZiZFRzWEx2MVQwNTA3blNWS2pUS1pq?= =?utf-8?B?RGFVbkxOVktjYmxzN003WUNxVExaN1VJYUU5M1V5MXk3VWxVblpKSHllOFRQ?= =?utf-8?B?Ykd3N3dsOFExRDlHUG14WGo2ZFNrdUZHNHNhYmpnei9yK2k3RElQMkd3b1di?= =?utf-8?B?U0NxNmYyUXJPQS9zT2xhZHdvNTVqY0k0QWwyb25MdGtjTWFRUkgvNGI0YVNB?= =?utf-8?B?VU9zTUhic3pMMExyb0dvb1gvY1I5Y3VLZDBWak42RlNRU2M3ay9kbThXbEhp?= =?utf-8?B?cyswVW1MNFMyc0hmMnBLb1FBMy8renpEQ21MYnBRWWJXbGk0VVdsTW1GUzNB?= =?utf-8?Q?GfYMTagYBPH2hC3Efx97cQ4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 38fab68d-0563-45f0-f79f-08d9f075e9d8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 11:25:47.6972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DQDumXoF+sm8aEoj3XaPdVy4L85wbzLsId9IDLJspjAJNMj7r1VzLtD6+BTheoxR1ToIbkqcDUsSVug+8sABgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4920 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 10:46 AM, Kevin Traynor wrote: > On 15/02/2022 10:06, Ferruh Yigit wrote: >> On 2/10/2022 1:09 PM, Radu Nicolau wrote: >>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size >>> being computed for TSO packets. >>> >>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >>> >> >> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, >> are we having the initial issue back when this patch reverted? >> Is there a fix for that initial issue? >> >> +Kevin, Luca, >> Since this patch reverts a fix done after 21.11, is there a way >> to stop that fix to be merged for 21.11.x? >> > > This revert patch would show up for us as a relevant one to backport, so in the worst case where initial fix was already pushed to dpdk.org, the revert would be taken too and the net result would be ok by release time. > > In this case, as the initial fix is not pushed to dpdk.org stable branches yet and as you have let us know, we can just make a note to skip it, or remove from a personal staging repo if already backported there. > ack > I'll add an email filter for 'reverts' to catch this so you won't have to ping manually, but feel free to do that as I suspect (hope :-)) it's only a handful of patches per release. > Ack. I was asking for a method, you adding a filter is a way, but if there is another defined method we (maintainers) can do it to help LTS maintainers. Like replying to a patch in stable list with a keyword, like 'do not apply this' to let your scripts to detect it ... > Thanks for highlighting, Kevin. > >>> Signed-off-by: Radu Nicolau >>> --- >>>    drivers/net/iavf/iavf_rxtx.c | 7 ++++--- >>>    1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c >>> index b0fed1b992..ba272bb211 100644 >>> --- a/drivers/net/iavf/iavf_rxtx.c >>> +++ b/drivers/net/iavf/iavf_rxtx.c >>> @@ -2464,9 +2464,10 @@ iavf_fill_data_desc(volatile struct iavf_tx_desc *desc, >>>        desc->buffer_addr = rte_mbuf_data_iova(m); >>>        /* calculate data buffer size less set header lengths */ >>> -    if (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG)) { >>> -        if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) >>> -            hdrlen += m->outer_l3_len; >>> +    if ((m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) && >>> +            (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | >>> +                    RTE_MBUF_F_TX_UDP_SEG))) { >>> +        hdrlen += m->outer_l3_len; >>>            if (m->ol_flags & RTE_MBUF_F_TX_L4_MASK) >>>                hdrlen += m->l3_len + m->l4_len; >>>            else >> >