From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A18C9A053B; Fri, 17 Jul 2020 16:07:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88B7E1BFE8; Fri, 17 Jul 2020 16:07:37 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E5FC5E07 for ; Fri, 17 Jul 2020 16:07:35 +0200 (CEST) IronPort-SDR: 3u3cPADA7KcOSzNXotky0PYxqYwEzKUM4VDnJ7H/+kbe5FC5UlPQoC56KlY2v4fhNtxBIbczqp ztI9FcOQabWg== X-IronPort-AV: E=McAfee;i="6000,8403,9684"; a="129674202" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="129674202" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 07:07:34 -0700 IronPort-SDR: dQaye/tyyi5+K0f700guIPjWJnkMX0NpRH1h59CkGDuOCeEeY2J4+xTOXCHXlzcCldt5RduENz cTGAsukHyyvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="286822826" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.225]) ([10.213.226.225]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2020 07:07:33 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-2-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: Date: Fri, 17 Jul 2020 15:07:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200701202359.17006-2-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 01/27] eal: rename terms used for DPDK lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > Replace the old use of master/slave lcore with more inclusive > name of initial/secondary lcore. The old visible API will > stay for now. > > Change master2slave to new init2worker and vice-versa. > > This patch breaks the expected practice for new API's. > The new rte_get_initial_lcore() will not go through the standard > experimental API phase; there is no functional difference > from the previous name. > > Signed-off-by: Stephen Hemminger > --- It's more difficult than it needs to be to review this patchset as it's out of date with current code. > diff --git a/doc/guides/nics/memif.rst b/doc/guides/nics/memif.rst > index ddeebed25ccd..9c67d7141cbe 100644 > --- a/doc/guides/nics/memif.rst > +++ b/doc/guides/nics/memif.rst > @@ -106,13 +106,13 @@ region n (no-zero-copy): > +-----------------------+-------------------------------------------------------------------------+ > | Rings | Buffers | > +-----------+-----------+-----------------+---+---------------------------------------------------+ > -| S2M rings | M2S rings | packet buffer 0 | . | pb ((1 << pmd->run.log2_ring_size)*(s2m + m2s))-1 | > +| S2M rings | M2S rings | packet buffer 0 | . | pb ((1 << pmd->run.log2_ring_size)*(w2i + i2w))-1 | > +-----------+-----------+-----------------+---+---------------------------------------------------+ > > S2M OR M2S Rings: > > +--------+--------+-----------------------+ > -| ring 0 | ring 1 | ring num_s2m_rings - 1| > +| ring 0 | ring 1 | ring num_w2i_rings - 1| > +--------+--------+-----------------------+ > This is probably a rebase error, looks like it belongs with the memif patch. > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 196eef5afab7..fb8f8a32beaf 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -79,6 +79,7 @@ DPDK_20.0 { > rte_hexdump; > rte_hypervisor_get; > rte_hypervisor_get_name; > + rte_init_lcore_id; Isn't it "rte_get_initial_lcore"? Also, as i've already mentioned in the response to the cover letter, i think "main lcore" would be more descriptive than "initial lcore". -- Thanks, Anatoly