From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 0E6E137A8
 for <dev@dpdk.org>; Fri, 20 Jan 2017 15:47:30 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 20 Jan 2017 06:47:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,258,1477983600"; d="scan'208";a="924791104"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga003.jf.intel.com with ESMTP; 20 Jan 2017 06:47:28 -0800
To: Andrew Rybchenko <arybchenko@solarflare.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1484841140-24117-1-git-send-email-arybchenko@solarflare.com>
 <18339814.hMek8iyv21@xps13>
 <a1b34174-a0bd-276f-1c0a-bdfd746b999e@solarflare.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ee32db21-c487-91e3-663e-58c0d53d8e2a@intel.com>
Date: Fri, 20 Jan 2017 14:47:27 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <a1b34174-a0bd-276f-1c0a-bdfd746b999e@solarflare.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2017 14:47:31 -0000

On 1/20/2017 2:37 PM, Andrew Rybchenko wrote:
> On 01/20/2017 05:29 PM, Thomas Monjalon wrote:
>> 2017-01-19 15:52, Andrew Rybchenko:
>>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>> ---
>>> It is a mistake that TSO support is compiled out by default.
>>> We would be happy to enable it by deafult, but strictly speaking
>>> it is not a bug fix.
>>>
>>> Arguments to enable are:
>>>  - be more feature-rich (and user-friendly) in default config
>>>  - the most of internal testing is done with TSO enabled
>>>
>>>  config/common_base | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/config/common_base b/config/common_base
>>> index b9fb8e2..134e9b9 100644
>>> --- a/config/common_base
>>> +++ b/config/common_base
>>> @@ -261,7 +261,7 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y
>>>  #
>>>  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=y
>>>  CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=n
>>> -CONFIG_RTE_LIBRTE_SFC_EFX_TSO=n
>>> +CONFIG_RTE_LIBRTE_SFC_EFX_TSO=y
>> There should not be such option in the build-time configuration.
>> Why keeping it (even enabled by default)?
> 
> Initially it was introduced since packet rates with TSO compiled out
> were slightly but noticeable better. Finally we have changed approach
> and performance improvements planned in 17.05 do not require it.
> I'll be happy to remove it completely, if there is no problems to
> include it in 17.02 (it will be a bit bigger but functionally equal to
> this one).

If it will be just removing ifdef, with keeping same functionality, I
wouldn't mind bigger patch.