From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3829B7CFC for ; Thu, 15 Mar 2018 10:02:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2018 02:02:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,308,1517904000"; d="scan'208";a="39095257" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.232]) ([163.33.230.232]) by orsmga001.jf.intel.com with ESMTP; 15 Mar 2018 02:02:37 -0700 To: Shreyansh Jain , Ferruh Yigit , "dev@dpdk.org" References: <20180307120851.5822-1-remy.horton@intel.com> <20180307120851.5822-2-remy.horton@intel.com> <023fbd6c-7cac-6c8b-9a40-7a62e5d47bb7@intel.com> Cc: Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Thomas Monjalon From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Thu, 15 Mar 2018 09:02:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 09:02:41 -0000 On 14/03/2018 15:10, Shreyansh Jain wrote: [..] >> What do you think renaming structure and variable name, >> "preferred_dev_config" perhaps? > > I missed this naming while reading this patch. In the deprecation > notice, 'preferred_size' was the name we came up with precisely on > this issue of structure having queue length and burst size. > > What about using that same name? Because of namespace issues it will need at least the rte_ prefix. Otherwise seems good to me as I cannot think of anything else that is relatively short.