DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector
Date: Wed, 29 Apr 2020 08:29:05 +0000	[thread overview]
Message-ID: <ee3cec6ff9c2444dbb54a5fc6c542d87@intel.com> (raw)
In-Reply-To: <20200429064906.11496-1-haiyue.wang@intel.com>

Dropped this patch, it is better to let the application to decide
the warning level.

BR,
Haiyue

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, April 29, 2020 14:49
> To: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Stokes, Ian <ian.stokes@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v2] eal: ignore alignment warnings for x86 vector
> 
> There several alignment warnings when including rte_memcpy header file
> externally like OVS for x86.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v2: Use __GUNC__ macro to apply for suppressing  the warning.
> ---
>  lib/librte_eal/x86/include/rte_memcpy.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h
> index ba44c4a32..d4cfe8dd5 100644
> --- a/lib/librte_eal/x86/include/rte_memcpy.h
> +++ b/lib/librte_eal/x86/include/rte_memcpy.h
> @@ -22,6 +22,10 @@
>  extern "C" {
>  #endif
> 
> +#ifdef __GNUC__
> +#pragma GCC diagnostic ignored "-Wcast-align"
> +#endif
> +
>  /**
>   * Copy bytes from one location to another. The locations must not overlap.
>   *
> --
> 2.26.2


  reply	other threads:[~2020-04-29  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  5:26 [dpdk-dev] [PATCH v1] eal: ignore alignment warnings for x86 Haiyue Wang
2020-04-29  6:49 ` [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector Haiyue Wang
2020-04-29  8:29   ` Wang, Haiyue [this message]
2020-04-29  8:40   ` Kevin Traynor
2020-04-29 16:17     ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee3cec6ff9c2444dbb54a5fc6c542d87@intel.com \
    --to=haiyue.wang@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ian.stokes@intel.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).