From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Shaikh, Shahed" <Shahed.Shaikh@cavium.com>
Cc: Xiaolong Ye <xiaolong.ye@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 6/8] net/qede: correct offload not supported mask
Date: Mon, 5 Nov 2018 10:21:50 +0000 [thread overview]
Message-ID: <ee4439c7-60d7-adf6-ea4e-0b19aa8b3024@intel.com> (raw)
In-Reply-To: <BYAPR07MB5511DC5228433D5CD13C30629DCA0@BYAPR07MB5511.namprd07.prod.outlook.com>
On 11/5/2018 6:52 AM, Shaikh, Shahed wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: Saturday, November 3, 2018 1:32 AM
>> To: Patil, Harish <Harish.Patil@cavium.com>
>> Cc: Xiaolong Ye <xiaolong.ye@intel.com>; Qi Zhang <qi.z.zhang@intel.com>;
>> Beilei Xing <beilei.xing@intel.com>; dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 6/8] net/qede: correct offload not
>> supported mask
>>
>>
>> On 10/27/2018 11:40 AM, Xiaolong Ye wrote:
>>> Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would
>> lead
>>> to unexpected result, correct it by using a NOT-AND operation.
>>>
>>> Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads")
>>>
>>> Cc: harish.patil@qlogic.com
>>> Cc: stable@dpdk.org
>>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>> ---
>>> drivers/net/qede/qede_rxtx.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h
>>> index d3a41e92e..9da059564 100644
>>> --- a/drivers/net/qede/qede_rxtx.h
>>> +++ b/drivers/net/qede/qede_rxtx.h
>>> @@ -159,7 +159,7 @@
>>> PKT_TX_TUNNEL_GRE)
>>>
>>> #define QEDE_TX_OFFLOAD_NOTSUP_MASK \
>>> - (PKT_TX_OFFLOAD_MASK ^ QEDE_TX_OFFLOAD_MASK)
>>> + ~(PKT_TX_OFFLOAD_MASK & QEDE_TX_OFFLOAD_MASK)
>>
>> Hi Harish,
>>
>> The qede usage can be problematic, because of how QEDE_TX_OFFLOAD_MASK
>> set:
>>
>> #define QEDE_TX_OFFLOAD_MASK (QEDE_TX_CSUM_OFFLOAD_MASK | \
>> PKT_TX_VLAN_PKT | \
>> PKT_TX_TUNNEL_VXLAN | \
>> PKT_TX_TUNNEL_GENEVE | \
>> PKT_TX_TUNNEL_MPLSINUDP | \
>> PKT_TX_TUNNEL_GRE)
>>
>> I am not sure if OFFLOAD_NOTSUP_MASK works fine with multi-bit values, I
>> think
>> you should set `PKT_TX_TUNNEL_MASK` here.
>>
>> But please double check in case I am missing something.
>
>
> Hi Ferruh,
>
> You are right. Tunnel types are multi bit values. Qede PMD does not support all tunneling protocol offloads which fall under PKT_TX_TUNNEL_MASK.
> Not sure how to handle unsupported tunneling protocols in OFFLOAD_NOTSUP_MASK.
>
> One way would be to set TX_TUNNEL_MASK in QEDE_TX_OFFLOAD_MASK and then check for unsupported tunnel protocols in tx_pkt_prepare().
+1, I think this would work
>
> Thanks,
> Shahed
>
next prev parent reply other threads:[~2018-11-05 10:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 10:40 [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 1/8] net/ixgbe: correct offload not supported mask Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 2/8] net/avf: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 3/8] net/ena: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 4/8] net/atlantic: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 5/8] net/fm10k: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 6/8] net/qede: " Xiaolong Ye
2018-11-02 20:02 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-05 6:52 ` Shaikh, Shahed
2018-11-05 10:21 ` Ferruh Yigit [this message]
2018-10-27 10:40 ` [dpdk-dev] [PATCH 7/8] net/vmxnet3: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 8/8] net/e1000: " Xiaolong Ye
2018-11-01 5:35 ` [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK Zhao1, Wei
2018-11-02 19:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-05 8:56 ` Ye Xiaolong
2018-11-05 10:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4439c7-60d7-adf6-ea4e-0b19aa8b3024@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Shahed.Shaikh@cavium.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).