From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6F27B37B7 for ; Fri, 14 Sep 2018 15:19:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2018 06:19:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,373,1531810800"; d="scan'208";a="70839522" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.151]) ([10.252.18.151]) by fmsmga008.fm.intel.com with ESMTP; 14 Sep 2018 06:19:20 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: Stephen Hemminger , dev@dpdk.org, Stephen Hemminger References: <20180830223512.21297-1-stephen@networkplumber.org> <20180830223512.21297-2-stephen@networkplumber.org> <20180914130646.cuyl55ycqfz2yvtp@bidouze.vm.6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 14 Sep 2018 14:19:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180914130646.cuyl55ycqfz2yvtp@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/5] bus/vmbus: add devargs support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 13:19:35 -0000 On 9/14/2018 2:06 PM, Gaëtan Rivet wrote: > Hi, > > On Fri, Sep 14, 2018 at 01:46:59PM +0100, Ferruh Yigit wrote: >> On 8/30/2018 11:35 PM, Stephen Hemminger wrote: >>> From: Stephen Hemminger >>> >>> Take device arguments from command line and put >>> them in the device devargs. >>> >>> Signed-off-by: Stephen Hemminger >> >> <...> >> >>> @@ -204,6 +203,27 @@ vmbus_parse(const char *name, void *addr) >>> return ret; >>> } >>> >>> +/* >>> + * scan for matching device args on command line >>> + * example: >>> + * -w 'vmbus(635a7ae3-091e-4410-ad59-667c4f8c04c3,latency=20)' >> >> This is just in comment but, >> >> I guess latest syntax is: >> -w "vmbus:635a7ae3-091e-4410-ad59-667c4f8c04c3,latency=20" >> >> @Gaetan, is latest devarg syntax documented somewhere? > > That's the current syntax indeed. Some documentation is found at > > lib/librte_eal/common/include/rte_devargs.h:100 > > Where it is specified that the bus name can be either omitted or > followed by any character, to separate it from the device identifier. > > This means that using ':' is fine, as well as '('. As long as the device > PMD afterward ignore the dangling ')' during devargs parsing, this should > be fine. > > I don't think this is very clean, but it works. Thanks for the info, I see how "(" works, but ")" is takes as part of argument and causing problem, I think better to not give "()" as supported syntax at all. btw, now both -w and --vdev are valid and can be used interchangeably, right? I mean all following are valid? -w pci:0000:86:06.0,enable_floating_veb=1 -w vdev:net_pcap,iface=lo --vdev pci:0000:86:06.0,enable_floating_veb=1 --vdev vdev:net_pcap,iface=lo