From: "Lu, Nannan" <nannan.lu@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
Date: Thu, 7 May 2020 01:52:21 +0000 [thread overview]
Message-ID: <ee5235b26f78419b87edb0a02e61322b@intel.com> (raw)
In-Reply-To: <20200507011541.66624-1-wei.zhao1@intel.com>
Tested-by: Lu, Nannan <nannan.lu@intel.com>
-----Original Message-----
From: Zhao1, Wei
Sent: Thursday, May 7, 2020 9:16 AM
To: dev@dpdk.org
Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Nannan <nannan.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:
"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"
Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ice/base/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
index 957142a10..a07ceea70 100644
--- a/drivers/net/ice/base/ice_switch.c
+++ b/drivers/net/ice/base/ice_switch.c
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
0x00, 0x57, /* PPP Link Layer 24 */
0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
- 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x3b, 0x00,
0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
--
2.19.1
next prev parent reply other threads:[~2020-05-07 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 1:15 Wei Zhao
2020-05-07 1:52 ` Lu, Nannan [this message]
2020-05-09 5:36 ` Zhang, Qi Z
2020-05-11 2:55 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee5235b26f78419b87edb0a02e61322b@intel.com \
--to=nannan.lu@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).