From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D13E43D14; Thu, 21 Mar 2024 11:34:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83A4842DB4; Thu, 21 Mar 2024 11:34:32 +0100 (CET) Received: from wfhigh6-smtp.messagingengine.com (wfhigh6-smtp.messagingengine.com [64.147.123.157]) by mails.dpdk.org (Postfix) with ESMTP id 6850A40261 for ; Thu, 21 Mar 2024 11:33:45 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.west.internal (Postfix) with ESMTP id 5C9D318000D1; Thu, 21 Mar 2024 06:33:44 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute3.internal (MEProxy); Thu, 21 Mar 2024 06:33:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711017223; x= 1711103623; bh=5dsMB+b45hkqxkDq+a+je/qWzhWKhYkJs5arjNpSpHc=; b=H k51ycSSvBFDVFRv6rbjihD9aHhNEQACGLkL/VTSLT5BD/KtHdgGwLZbB+uiD4xdU BDnuOmZ+qt6XBEwwer8jxfJ4hpQNNstYu+HDVZv4t9Yp0HZkGdPEKNLrquywrwq7 xveLsTu5h51liM9Bsj4hHFbgKsQ12UoFYwJESFK0/MnYUANvNx12IGVPaRsy1FrX gZWGkL1ByDxzAFFTFV0UvNlWShZyUaih48P9wIJFC93S0OkodS4fvowf2uP0SSFV JkTF7NHZvAFGhjNzsEuEwwj6y6qMbveGCwkBek4VXDqRzv86K4nCOHkMUsI6EzaV Knx9lILR0VOf1p/48Y1YQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleeigddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedfvfho mhculfhonhgvshdfuceothhhjhesfhhrvggvsghsugdrohhrgheqnecuggftrfgrthhtvg hrnhepvdfgfeeltdegffehtdeigfeifffhfefhhfehteejkedvkeeuudevhedtieeuueei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhjh esfhhrvggvsghsugdrohhrgh X-ME-Proxy: Feedback-ID: ib75146ab:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B0A68A6007A; Thu, 21 Mar 2024 06:33:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940 MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20240320130255.1526-1-thj@freebsd.org> <20240321095029.1216-1-thj@freebsd.org> Date: Thu, 21 Mar 2024 10:33:22 +0000 From: "Tom Jones" To: "David Marchand" Cc: dev@dpdk.org, "Bruce Richardson" Subject: Re: [PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 21 Mar 2024 11:34:30 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 21, 2024, at 10:15, David Marchand wrote: > Hello Tom, > > On Thu, Mar 21, 2024 at 11:00=E2=80=AFAM Tom Jones w= rote: >> >> Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 dri= ver >> as they are not supported. Rx queue interrupts were missed by this >> change, don't attempt to enable them on FreeBSD. >> >> Without this change applications enabling interrupts encounter an >> immediate abort on FreeBSD. > > Thanks for the patch, you will probably want this fix backported in > LTS versions. > If so, please add a Fixes: tag and Cc: stable@dpdk.org. > I guess here, it is: > Fixes: 40d5676ff1ea ("net/vmxnet3: fix initialization on FreeBSD") Thanks! updated > > Reading again the commitlog, I wonder if we should error out in > vmxnet3_configure_msix() if rx (and/or lsc) interrupts are requested > for FreeBSD. > Did you consider this approach? > I haven't dug much futher into this. I also changed the application side= (vpp) to not request interrupts. I think there are probably some other = FreeBSD specific cases to explore in vmxnet3, but I don't have a great e= nvironment for testing yet. - Tom