DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Patrick Robb <probb@iol.unh.edu>, paul.szczepanek@arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] dts: add sudo to linux link up
Date: Thu, 30 Jan 2025 08:15:39 +0000	[thread overview]
Message-ID: <ee80ed08-0446-450c-975b-f8cdd6796cc6@arm.com> (raw)
In-Reply-To: <20250129220810.261925-1-probb@iol.unh.edu>

Hi Patrick,

thank you for the prompt fix!

On 29/01/2025 22:08, Patrick Robb wrote:
> Fixes: 41d133d6c62f ("dts: automatically bring up link on interfaces")
> Cc: probb@iol.unh.edu
> 
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>   dts/framework/testbed_model/linux_session.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py
> index e77fe9b692..d811d002ca 100644
> --- a/dts/framework/testbed_model/linux_session.py
> +++ b/dts/framework/testbed_model/linux_session.py
> @@ -169,7 +169,7 @@ def update_ports(self, ports: list[Port]) -> None:
>       def bring_up_link(self, ports: list[Port]) -> None:
>           """Overrides :meth:`~.os_session.OSSession.bring_up_link`."""
>           for port in ports:
> -            self.send_command(f"ip link set dev {port.logical_name} up")
> +            self.send_command(f"sudo ip link set dev {port.logical_name} up", verify=True)

sudo should be performed with `privileged`:

     self.send_command(f"ip link set dev {port.logical_name} up", 
privileged=True, verify=True)

>   
>       def _get_lshw_info(self) -> list[LshwOutput]:
>           output = self.send_command("lshw -quiet -json -C network", verify=True)



  reply	other threads:[~2025-01-30  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 22:08 Patrick Robb
2025-01-30  8:15 ` Luca Vizzarro [this message]
2025-01-30 13:53 ` Patrick Robb
2025-01-30 14:11   ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee80ed08-0446-450c-975b-f8cdd6796cc6@arm.com \
    --to=luca.vizzarro@arm.com \
    --cc=dev@dpdk.org \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).