From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F89246148; Thu, 30 Jan 2025 09:15:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFDF140275; Thu, 30 Jan 2025 09:15:43 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 51A0340156 for ; Thu, 30 Jan 2025 09:15:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E3DB497; Thu, 30 Jan 2025 00:16:07 -0800 (PST) Received: from [10.1.39.11] (JR4XG4HTQC.cambridge.arm.com [10.1.39.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F24463F5A1; Thu, 30 Jan 2025 00:15:40 -0800 (PST) Message-ID: Date: Thu, 30 Jan 2025 08:15:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dts: add sudo to linux link up Content-Language: en-GB To: Patrick Robb , paul.szczepanek@arm.com Cc: dev@dpdk.org References: <20250129220810.261925-1-probb@iol.unh.edu> From: Luca Vizzarro In-Reply-To: <20250129220810.261925-1-probb@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Patrick, thank you for the prompt fix! On 29/01/2025 22:08, Patrick Robb wrote: > Fixes: 41d133d6c62f ("dts: automatically bring up link on interfaces") > Cc: probb@iol.unh.edu > > Signed-off-by: Patrick Robb > --- > dts/framework/testbed_model/linux_session.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py > index e77fe9b692..d811d002ca 100644 > --- a/dts/framework/testbed_model/linux_session.py > +++ b/dts/framework/testbed_model/linux_session.py > @@ -169,7 +169,7 @@ def update_ports(self, ports: list[Port]) -> None: > def bring_up_link(self, ports: list[Port]) -> None: > """Overrides :meth:`~.os_session.OSSession.bring_up_link`.""" > for port in ports: > - self.send_command(f"ip link set dev {port.logical_name} up") > + self.send_command(f"sudo ip link set dev {port.logical_name} up", verify=True) sudo should be performed with `privileged`: self.send_command(f"ip link set dev {port.logical_name} up", privileged=True, verify=True) > > def _get_lshw_info(self) -> list[LshwOutput]: > output = self.send_command("lshw -quiet -json -C network", verify=True)