From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10D72433EF; Tue, 28 Nov 2023 09:54:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D75F2410DD; Tue, 28 Nov 2023 09:54:05 +0100 (CET) Received: from office2.cesnet.cz (office2.cesnet.cz [78.128.248.237]) by mails.dpdk.org (Postfix) with ESMTP id 3F8FF40E54 for ; Tue, 28 Nov 2023 09:54:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1701161643; bh=z2oSyVjNn4LUZ3VyVHH085KzHp5q87Eyj37s/q8qQZc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PPw0e/t3R9sVchMBtjQOFp3u8YOuv2MKsohW8CksOSjmE8UVV2g6H0DAhvv6PnvEM oh5pEeGlB5HC8BsOVv2PMmZw6TqIxM+5emZPco4LjiMeSZKQrTGKvwVJAcxa1osmBs U1ZJh3wxHmCEYM0EB68768YiLUcX+3LBb9aheAynbbrQoObo24RWTqaZH8cgW9IG5n Hyq8Lh2I0NJLVVl+EIVzIUhfswFIQCPDVe9HumDt2lnNV/NOEa36b0L9S8qyanlOsh RaJ4pf94EMiFa6UuTLOYzIZjoVqBPRCp8qNlXPF63cYcFeRPHojAlVlKTQ1SGCPWk4 lXOyI+P7ax1zw== Received: from [IPV6:2001:67c:1220:80e:93:a24f:6f5b:26b4] (unknown [IPv6:2001:67c:1220:80e:93:a24f:6f5b:26b4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 05B3D1180111; Tue, 28 Nov 2023 09:54:02 +0100 (CET) Message-ID: Date: Tue, 28 Nov 2023 09:54:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] eal: introduce missing rte_thread wrappers Content-Language: en-US To: Tyler Retzlaff Cc: dev@dpdk.org References: <20231127092502.18510-1-vodak@cesnet.cz> <20231127172722.GA14975@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Vodak In-Reply-To: <20231127172722.GA14975@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/27/23 18:27, Tyler Retzlaff wrote: > On Mon, Nov 27, 2023 at 10:25:02AM +0100, David Vodak wrote: >> Function rte_ctrl_thread_create has been replaced by rte_thread_create_control, >> encouraging Linux users to switch from the pthread_t API to the rte_thread API. >> However the rte_thread API does not provide wrappers for all pthread functions. >> This commit introduces equivalent functions for pthread_timedjoin_np, >> pthread_getname_np and pthread_cancel. >> >> Bugzilla ID: 1330 >> --- > NAK this series. the rte thread API is not a POSIX emulation API. > > the point of EAL is not to require applications to have to conditionally > compile code around the use of EAL API or handle "not supported" > failures it defeats the purpose of being an abstraction library. Hi, I understand that these changes may not be the best alternative. But what other options do we have, if we are already using functions such as pthread_timedjoin_np? Should we just keep using them and treat rte_thread_id.opaque_id as pthread_t? Regards David Vodak