From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3AB4CA0471 for ; Thu, 20 Jun 2019 09:25:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C2411D03E; Thu, 20 Jun 2019 09:25:23 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9C61F1D011 for ; Thu, 20 Jun 2019 09:25:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B6E1F300159E; Thu, 20 Jun 2019 07:25:20 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E2295D719; Thu, 20 Jun 2019 07:25:19 +0000 (UTC) To: Matan Azrad , Tiwei Bie Cc: Noa Ezra , "dev@dpdk.org" References: <1560924825-220648-1-git-send-email-noae@mellanox.com> <1560924825-220648-2-git-send-email-noae@mellanox.com> <59325f03-2a0a-27a9-5995-bb60f22a98b5@redhat.com> <20190620022609.GA4168@___> From: Maxime Coquelin Message-ID: Date: Thu, 20 Jun 2019 09:25:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 20 Jun 2019 07:25:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/20/19 8:08 AM, Matan Azrad wrote: > > > Hi Tiwei, Maxim > From: Tiwei Bie >> Sent: Thursday, June 20, 2019 5:26 AM >> To: Maxime Coquelin >> Cc: Noa Ezra ; Matan Azrad ; >> dev@dpdk.org >> Subject: Re: [PATCH 1/2] net/vhost: support TSO disabling >> >> On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wrote: >>> On 6/19/19 8:13 AM, Noa Ezra wrote: >>>> TSO (TCP Segmentation Offload) is enabled by default on vhost. >>>> Add the ability to disable TSO on vhost. >>>> The user should also disable the feature on the virtual machine's xml. >>> >>> For TSO, I think it make sense to have the option to disable it, as it >>> requires the application to support it. >>> >>> I even wonder whether it should not be disabled by default. >>> Any thoughts? >> >> Agree, it looks better to disable it by default. > > The issue to disable it by default is that it will break the current applications/users which use TSO by default. > > Maybe we need kind of notice to the user to break it in the next version. > > What do you think? I think that's a good idea, let's add a notice in the release note for v19.08, and disable it by default in 19.11. Thanks, Maxime >> Thanks, >> Tiwei