From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A67FA37B7 for ; Thu, 13 Sep 2018 11:03:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 02:03:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,368,1531810800"; d="scan'208";a="88387481" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by fmsmga004.fm.intel.com with ESMTP; 13 Sep 2018 02:02:55 -0700 To: Xiaoyun Li , wenzhuo.lu@intel.com, dev@dpdk.org References: <20180910163753.85966-1-xiaoyun.li@intel.com> <20180910163753.85966-3-xiaoyun.li@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Thu, 13 Sep 2018 10:02:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180910163753.85966-3-xiaoyun.li@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/8] net/ixgbe/base: cleanup codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 09:03:10 -0000 On 9/10/2018 5:37 PM, Xiaoyun Li wrote: > Cleanup UNREFERENCED_1PARAMETER() macro because "hw" is used. > And remove Light Spring codes because the device was never > productised. And cleanup unused bypass codes. > > Signed-off-by: Xiaoyun Li This patch breaks the build because IXGBE_DEV_ID_82599_LS removed, the code using it removed at patch 7/8 but in between build is broken. Please send a new version patches re-arranged, thanks.