From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C78FBA0561; Wed, 17 Mar 2021 22:47:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70E4F140F60; Wed, 17 Mar 2021 22:47:36 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 781B5140F55 for ; Wed, 17 Mar 2021 22:47:35 +0100 (CET) IronPort-SDR: LUjhb6uiSa9qmkhy8FrdK104XeaMm9lD5ULmrvby6eBM42qf51TJqGNcJ09VMoc7Wo83dQ0F5m HS3wrIiQNiLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="189598168" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="189598168" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 14:47:34 -0700 IronPort-SDR: 3LDWWWUJ/lQvwQWrH7pOfqNsjTXJPiIBQSGgU8E+UunFJhoX30KFI8w7lGYrhNGtmR8Q4lCzom K6K5cGR1aP4g== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="406088501" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.22.40]) ([10.252.22.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 14:47:29 -0700 To: Qi Zhang , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210317111551.2215332-1-qi.z.zhang@intel.com> <20210317111551.2215332-3-qi.z.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 17 Mar 2021 21:47:26 +0000 MIME-Version: 1.0 In-Reply-To: <20210317111551.2215332-3-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 2/9] net: replace build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/17/2021 11:15 AM, Qi Zhang wrote: > Replace RTE_LIBRTE_ETHDEV_DEBUG with RTE_ETHDEV_DEBUG. > > Signed-off-by: Qi Zhang Hi Qi, Thomas, I see Thomas mentioned 'LIBRTE_' is redundant but not sure about renaming the existing compile time flag without notice. The flag is to be used for users, it is not internal, and it may be already used in some scripts and automation etc, this rename can break them. 'LIBRTE_' is already used commonly, I think all library flags has it, do we really need to drop it from this current one? Even if we drop it, what about keeping it as alias for backward compatibility?