From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77841A04BC; Fri, 9 Oct 2020 17:59:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA2C51D6E5; Fri, 9 Oct 2020 17:59:15 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 338101D6DD; Fri, 9 Oct 2020 17:59:13 +0200 (CEST) IronPort-SDR: PowGlH6PEcn3QwDoGJHVGRvNKYTQgmlaLLyfQKgwLY4q3kNJNB/C9sCqr5jha4cD0m1X2Ipykk DWgP3R2rXW1g== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="153335446" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="153335446" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 08:59:08 -0700 IronPort-SDR: uy1iT1H120HkJxu3EqhqENGgW5OUDf9lAId5YQvGmfVhf33T32mAoCxGUfrnP/imexVl2M09yR YPlB3WZhx0hQ== X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="462236789" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.7]) ([10.252.18.7]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 08:59:07 -0700 To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)" , Honnappa Nagarahalli , "dev@dpdk.org" , Phil Yang Cc: nd , "stable@dpdk.org" References: <20200921192254.20560-1-honnappa.nagarahalli@arm.com> <20200928190334.40624-1-honnappa.nagarahalli@arm.com> From: Ferruh Yigit Message-ID: Date: Fri, 9 Oct 2020 16:59:03 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/2020 12:23 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) wrote: >>> -----Original Message----- >>> From: Honnappa Nagarahalli >>> Sent: Monday, September 28, 2020 2:03 PM >>> To: dev@dpdk.org; Honnappa Nagarahalli >> ; >>> Phil Yang ; jgrajcia@cisco.com; >>> ferruh.yigit@intel.com >>> Cc: nd ; stable@dpdk.org >>> Subject: [PATCH v2 1/8] net/memif: do not update local copy of tail in >>> tx function >>> >>> In the case of S2M queues, the receiver synchronizes with the sender (i.e. >>> informs of the packets it has received) using ring->tail. >>> Hence, the sender does not need to update last_tail. >>> >>> In the case of M2S queues, the receiver uses last_tail to keep track >>> of the descriptors it has received. The sender is not required to update the >> last_tail. >>> Updating the last_tail makes it a shared variable between the >>> transmitter and receiver affecting the performance. > > Hi Honnappa, > > The patch series is looking good. > > Reviewed-by: Jakub Grajciar > Series applied to dpdk-next-net/main, thanks.