From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEDBCA04DD; Tue, 20 Oct 2020 12:28:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9B00ACB9; Tue, 20 Oct 2020 12:28:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 785ECAC78; Tue, 20 Oct 2020 12:28:04 +0200 (CEST) IronPort-SDR: cWQ1bwnQAf2ShAEDMzqnq4DqeNqDewXgvLi9OuBzm7VM0FhucJqKHKxtem+ceeabTzyIBZSTM3 p8DysvfXhNnw== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="251881469" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="251881469" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 03:28:02 -0700 IronPort-SDR: zy8icvcPUMUcvhWPX7+Ih1q47SGnlRXiSsFZXealtc4htDWHyoKuaanmi+6ddN5x3Ju+D18yGO RRiRDAVEq6/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="347812794" Received: from irsmsx602.ger.corp.intel.com ([163.33.146.8]) by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2020 03:28:02 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by irsmsx602.ger.corp.intel.com (163.33.146.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 11:28:00 +0100 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 20 Oct 2020 18:27:58 +0800 From: "Zhang, Qi Z" To: "Rong, Leyi" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/iavf: fix unchecked Tx cleanup error Thread-Index: AQHWpd3ExwYT8r6E3UCO0CYwz+9GOamgS4AQ Date: Tue, 20 Oct 2020 10:27:58 +0000 Message-ID: References: <20201014082857.81080-1-leyi.rong@intel.com> <20201019054253.105559-1-leyi.rong@intel.com> In-Reply-To: <20201019054253.105559-1-leyi.rong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix unchecked Tx cleanup error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Rong, Leyi > Sent: Monday, October 19, 2020 1:43 PM > To: Zhang, Qi Z ; Yigit, Ferruh > Cc: dev@dpdk.org; Rong, Leyi ; stable@dpdk.org > Subject: [PATCH v2] net/iavf: fix unchecked Tx cleanup error >=20 > Coverity complains of unchecked return value warning of iavf_xmit_cleanup= , > while this cleanup is opportunistic and will not cause problems if it fai= ls. So > instead of checking the return value of iavf_xmit_cleanup and return in c= ase of > cleanup failure, we directly cast it to void function to make the Coverit= y happy. >=20 > Coverity issue: 363045 > Fixes: 02d212ca3125 ("net/iavf: rename remaining avf strings") > Cc: stable@dpdk.org >=20 > Signed-off-by: Leyi Rong Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi