From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 8A13D2A66
 for <dev@dpdk.org>; Thu,  8 Dec 2016 17:48:35 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga104.fm.intel.com with ESMTP; 08 Dec 2016 08:48:34 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,320,1477983600"; d="scan'208";a="910146450"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by orsmga003.jf.intel.com with ESMTP; 08 Dec 2016 08:48:33 -0800
To: Harish Patil <harish.patil@qlogic.com>, dev@dpdk.org
References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com>
Cc: Dept-EngDPDKDev@qlogic.com, Rasesh Mody <Rasesh.Mody@cavium.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <eedda5d5-a276-70c2-41a5-431c6fa1e128@intel.com>
Date: Thu, 8 Dec 2016 16:48:32 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Dec 2016 16:48:35 -0000

On 12/3/2016 2:43 AM, Harish Patil wrote:
> From: Rasesh Mody <Rasesh.Mody@cavium.com>
> 
> Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with
> CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value
> where each bit represent a particular submodule to debug. Also move
> notice messages under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <Rasesh.Mody@cavium.com>
> ---

Is 32bit supported by driver?

If so it is throwing a compilation error for it [1], if not can you
please document it?

[1]
In file included from .../drivers/net/qede/base/ecore.h:35:0,
                 from .../drivers/net/qede/qede_ethdev.h:22,
                 from .../drivers/net/qede/qede_ethdev.c:9:
.../drivers/net/qede/qede_ethdev.c: In function ‘qede_rss_hash_update’:
.../drivers/net/qede/base/../qede_logs.h:33:3: error: format ‘%lx’
expects argument of type ‘long unsigned int’, but argument 7 has type
‘uint64_t {aka long long unsigned int}’ [-Werror=format=]
   "[%s:%d(%s)]" fmt, \
   ^
.../drivers/net/qede/qede_ethdev.c:1472:2: note: in expansion of macro
‘DP_INFO’
  DP_INFO(edev, "RSS hf = 0x%lx len = %u key = %p\n", hf, len, key);
  ^~~~~~~
cc1: all warnings being treated as errors


<...>