From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 762E5A0521; Tue, 3 Nov 2020 16:28:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE707CB93; Tue, 3 Nov 2020 16:28:51 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 492DECB7F for ; Tue, 3 Nov 2020 16:28:50 +0100 (CET) IronPort-SDR: mAqc4W+rqj2dUWsLFGW/8e3iLU2/3I0iFCtAbQsMsAbatGNzjAtK+IKKXK6zPERI/hdPDdkJL7 Pz3xSrPq4rBw== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="169174761" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="169174761" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 07:28:48 -0800 IronPort-SDR: 2s/qfBcjdTKBxikF225sKHVPzQap1Gp/cLxt67QLKGN3RR35TYZIc4MJ9PpyewbD/uOboHpuIa PTgVkr+HOl0g== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538525062" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 07:28:46 -0800 To: Bruce Richardson , Leyi Rong Cc: qi.z.zhang@intel.com, dev@dpdk.org References: <20201103125629.56030-1-leyi.rong@intel.com> <20201103135200.41166-1-leyi.rong@intel.com> <20201103135200.41166-3-leyi.rong@intel.com> <20201103144400.GF1144@bricha3-MOBL.ger.corp.intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 3 Nov 2020 15:28:43 +0000 MIME-Version: 1.0 In-Reply-To: <20201103144400.GF1144@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 2:44 PM, Bruce Richardson wrote: > On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote: >> Fix the build error when -march=skylake-avx512 is not supported on >> lower version GCC. >> >> Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") >> >> Signed-off-by: Leyi Rong >> --- >> drivers/net/iavf/meson.build | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build >> index e257f5a6e1..099b6a725d 100644 >> --- a/drivers/net/iavf/meson.build >> +++ b/drivers/net/iavf/meson.build >> @@ -46,12 +46,16 @@ if arch_subdir == 'x86' >> >> if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true >> cflags += ['-DCC_AVX512_SUPPORT'] >> + avx512_args = [cflags, '-mavx512f', '-mavx512bw'] >> + if cc.has_argument('-march=skylake-avx512') >> + avx512_args += '-march=skylake-avx512' >> + endif >> iavf_avx512_lib = static_library('iavf_avx512_lib', >> 'iavf_rxtx_vec_avx512.c', >> dependencies: [static_rte_ethdev, >> - static_rte_kvargs, static_rte_hash], >> + static_rte_kvargs, static_rte_hash], > > This is an unnecesary whitespace change that can be dropped from the patch, > and doesn't actually clean things up, since the extra indent is useful to > show the continuation of the array. > >> include_directories: includes, >> - c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) >> + c_args: avx512_args) >> objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c') >> endif >> endif >> -- > > Acked-by: Bruce Richardson > Squashed into relevant commit in next-net, thanks. Indentation change dropped while merging.