From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8177342477; Tue, 24 Jan 2023 10:08:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7145F40150; Tue, 24 Jan 2023 10:08:02 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2080.outbound.protection.outlook.com [40.107.92.80]) by mails.dpdk.org (Postfix) with ESMTP id 9E4B5400EF for ; Tue, 24 Jan 2023 10:08:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VDGkt2ZvRSCiClJVXDymp136puNq0aCREGNGSqBJvhX8ONFwAmtzmccrmvQI/bgqbZRaFHCAJI9EpbV3EDRHcEnC7yxFoIhNuf6HDamRGbDApWCtBirx6zzfMvJP3vJL4FVlIEDgFr5Kww/mylIA2QpWpToJjyWRcZnoOhVjSJ0404qmFWA0Q4sNTrqKD90AEOBrd/kab6papZcdt3WL0sveV51WpJZvtzWBzvDFF83JI2q5UjiVdOd1SR97LT1gmehStV4/8mgnRthHAlqDDjrV1NRUN5qC64ebG6I1qMeyqgA0qwvSLTxcGQ9R5sirAMgXxUUQfJsO4aPNHHm7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5yKgNOuNlu8xIBASdpZ8uKMhwE8zinx8EVa5fpkDJmA=; b=JDq3dn3GNu1DeJB8TiUMK1iPkqnYEhiMriRKFjqkYSjDaDXGMj13OZdZ55//B4BkudxP395FQEiWgnolXHUDPvu5F1Opq09hvvYcaW5EXX/HVlC7YJMIihedGaUTw3kKj4R8wGwDIAgcnSfz2JC8yrRgMgVj/vpFmTbBgNiejc2a+XbO9FhPpF0zO6eIM93xWTGQS1AwSpM1y4toj2GEx4yj8nv8n76rnJ9RMLf6r9ipKCa6YMpnx11cm9MuZfh8K3pf+FFfkd0MsnIiPG/0Uj/m+CK/w5seQxaQE8iOE34jRnvxI3AsdndQGw7xqIo2tqEzMW7bJwRbgW1YonvMAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5yKgNOuNlu8xIBASdpZ8uKMhwE8zinx8EVa5fpkDJmA=; b=JJTU6N6MIWkFjBlKquifdhcdZH/eq+GYnZ9aVZ4a+Nvp00epnCPx6Bv325pjnkPTZ0N6pxVAJ4/+n4YO8DbQwIcC2B6a3LhFiOOWl4HOx8HB3JWIVWV9nok5tXIGp7SSGUjXHcaaND3agoLG1ASPu6q1W9MJ79VwO2xiotYVE6Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB8360.namprd12.prod.outlook.com (2603:10b6:208:3d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 09:07:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 09:07:58 +0000 Message-ID: Date: Tue, 24 Jan 2023 09:07:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 0/8] start cleanup of rte_flow_item_* Content-Language: en-US To: David Marchand , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org References: <20221025214410.715864-1-thomas@monjalon.net> <20230120171902.4188088-1-ferruh.yigit@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0585.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB8360:EE_ X-MS-Office365-Filtering-Correlation-Id: e05e066c-9e30-4936-591d-08dafdea7c71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: emQHjFqaba0V8GfWdnDpeowf8yFjnP7Xl0U6IBIzgwCGyNSnhAWPhHA6r22VZdjtDoeHDNiD1jRwa4km+kHpqk/m22wkLVnrOXHS7gZ8Fg38oP99H5lZ2AwDn4oYpgBvA6UcAvRKoM+Y6StMyPPhOZzJkrLZYJK5lC17DbEJ/P4yj8TpOOLHgFm3FboPyhWX/PFPeUKCVWDDVhtBnIVa1/fQvi0uKycmFADkbPYxSzjvlbeBnOmdphd4O4LFPC/XwmZH3L/1GS3zNgNIcZVnFvi03iBe+7I3c+urLZL/HJUyg+NcKyeSzI6Q2elNhHBTK1Z5Tl3thdBvemOCgJZPPdvCUHWT5FEfRKk1Sw/wVMooknxopC0m/2dsaSS7DDX5bw0HrN1ahYK4TmhHDotW6yIK9DLo7gU8LmMh58I0Guap0ulpqDl7497iuHCwFhNRfY74yMUnv18G+KBtFfQr4Tbw/QncrueFuPt17Hy0EdA02kdfZB9DTPvcSPhKQtyTL8tcfUpm/PvLv+T/ciljMUeSshEgq3bBoMSbTqvziIO0dR0pVf1IKbU9LFy+oQgwgpn8swirJ8BNBFOrJetwy7NDzSImNkYUvvpxM8dKR1QGjwIH5Jc1QIipW+gSspKMF9hn/4IgpmSOUzaQxJPx5ALc0hl2JiEdmt4tQGa/DNiE7BtG/ONkOFxry0wDHtrJlSdxE7oBrIjY++XoEmAToI/T+roS5rzVX/bvoDoiOfn7/a1l2f7FL+dMOXAh8m/qcwPbxgXsMVHIFrAEIGMoJ/XlfLdfmHznAx2/MDGe293lb3zu9Dx+DDUSdX+YIGRZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199015)(36756003)(316002)(8676002)(86362001)(4326008)(66946007)(66476007)(66556008)(110136005)(186003)(26005)(6512007)(6666004)(53546011)(83380400001)(6506007)(966005)(6486002)(478600001)(2616005)(31686004)(44832011)(5660300002)(8936002)(31696002)(41300700001)(2906002)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjkvV1NCVHJiRXo3bWVaSGtHcDMwUkRkRGV6SkozVVFxQkEzeFdEUWRqRy9n?= =?utf-8?B?YUdZVTU1N1BJQjRxMW1saDlpZnFQaXUrRWQxK2tCWkp1MGo1eTdyaW8ydnZi?= =?utf-8?B?NFd3VTQyR0ttZXJPbEgzMXM3anUvd2o1SytMMEt4YXh2eXA5T2JSOTZ1M0ZP?= =?utf-8?B?ckZmZVpkSUtKcEVISEhqUHhSM0w2V0J1OEg2UnFaNE5SQTBRbWY0eWdQTFVs?= =?utf-8?B?cmRDcGJVdVpZQVFOZ1krV0xWUU93L1JuZnl2d1NkVkNRR3orQ1RINUhzc281?= =?utf-8?B?VjU2U3V2N2ZRNDVOSzVhUGhvNkhRa0VQeVJUMVArbm5HQzFsTGs2WlZ3cVZN?= =?utf-8?B?Vi8wRDVHRnVnOHkwZ25mZE1wZmZMKzBKY3Z3Y0Y4OWRnUUtIYjdhZkhRQitn?= =?utf-8?B?eVU2dXdmUGpybmhER0M3WmNNUjkyR1JkM2hsZ1hPT0NETHpaR2NFUVJpMTFh?= =?utf-8?B?b3UvNGxDYnBmVng0VzNWTUJvUERYV2RqbWE3VkloNUN2cFRLUmtnS3RyMDYy?= =?utf-8?B?TkcxT040ZDAybkVYdG8xR3o5Q1NkZHV3SFlzejlQME1JQVBjbHlYL3k1Q29q?= =?utf-8?B?SG5zSldXalBuMzRycWJsdk1DcUVCcllJdjJlRllpMENEbERrWnRhaUx0bzk4?= =?utf-8?B?UFFVV01XTEUwWlk5aDBpNVRKZHdNK1JJK2U0b1ZoZGlsc0MxUll4bHgxM0Uw?= =?utf-8?B?M1RVaFJuL1BGSmVlUUl5MSt0QnJrQXVUd0xNOHROTHp6bTdJbndTOVh0aUZy?= =?utf-8?B?Tmo0bGpTRjgvWXlRbm1vMUNsSDBUK2hjaUJ1ckFEUUpmQkRPRzZCODBJZjJz?= =?utf-8?B?dzA0dFc0MWFkMEpKMnFpOXI4NXk0T2s3cjRSTTZJL3BGclgra1diNmtpUnJy?= =?utf-8?B?cnN3dWpMNzJyU1NGdWtVRXd6eHd6TmxDWlhUNUNDSEQ3bWI3am1zd2JUV01P?= =?utf-8?B?RXRyb2gzUHpEcmRXTHVPV1RtVG9DWHNrVUxpR1UxU1pGTXBjRWFqSnFwanRn?= =?utf-8?B?SWhuUENTdHVBUmMrUjY5TmNjRDhSZ2NIMU9YKzFKaFN3Vkg3OCtJSjNGK3NT?= =?utf-8?B?T2RCeW5QVDV6MGtzMHRmVkVxRVhsZUdHbTNySE85QkN6NGlZS0VTU29nRWM4?= =?utf-8?B?cFlUa2RBc2w5NElnazhuS0lkWXBFdE9qcnI4RFRkbFppMytaWloyNTg3ei8v?= =?utf-8?B?MXZIaXZzZUg5bHBZMmpzeHRDSkZzTHd2S1hYWmlUSUx1ME1wWVpwTmY2enZY?= =?utf-8?B?L1h4eUJXWldxZndtNk90Q3ZLd3FEb1RadEZLcXJrZ3ZJOXA3MEFLN2tBM3hR?= =?utf-8?B?T2V2VVJqcmhDYlQ5Q3BqbEExakMwR2N5TkVlT0E3ZE9LbWlRTmJOZjdQblFH?= =?utf-8?B?bXZ3MXdmdlhvNzEycW1LR3ArclBnaE9rSGI5VlR6VHJjb0U5OEdTdGhndjVz?= =?utf-8?B?MDZNQU1Xbk1UWXJRUWRhdm1VQmVTdlpZOTh2MU9QdnRFUkRxSFdmMGwvTFEx?= =?utf-8?B?Tkk5WnVYeStvWENISEY2M2hFVGNlT3EwM1NMWU1PNlhpa3FCekxGamVhQXFL?= =?utf-8?B?WWVjc0ZickxtR3ByS2VxNU12bDM4NHBCdVpURXZ3MS9RcGRrc0hNTkNjeXFs?= =?utf-8?B?amJYWk9FSzlSUDBqUTY3MTRVMjh4QzdyZ05vK3ZZMVZ3Nlhuak0rbU01VEls?= =?utf-8?B?aHplVzhucWZRa1lxN3duSG9PN0MyeXRhZ1NqQ3B2Rk8zNWt2OEpCM1pnYXlY?= =?utf-8?B?Sy8xTms2bDYrZ1c4V3lzNEtDTjBOSUNubThIc2hNSENFRys5VnNWSFRWcXhC?= =?utf-8?B?TVlyU1FqaWtqdUczSnF2U1AvRms5amtETzJQc1BqVCtCSThpOEJYc1dVZmQ5?= =?utf-8?B?cDRudWUvclVrVmE2ZG11SjlWNjR1TVh3QjhmY3JyNlRjdmlOc2o3YitmZmQv?= =?utf-8?B?TFlhdWVvRms5UzFBZG9pTGlxbUZ6bWlrY2NGS2owci9SNTVLWE9RNWNyaHRH?= =?utf-8?B?MVAxK2ZFZU05QlpFRlVycVdZY0k5b2VVcnJyUlpqajJVajh1ZGVPVHRxNzQy?= =?utf-8?B?YjlVbG1iV05naWVyQUZSaDFIMUJyb3hsNG1jK0ZOTElhWkc4WlE5RzNra2d5?= =?utf-8?Q?wwwtQBr79/HG3/jEpp7G7UlYI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e05e066c-9e30-4936-591d-08dafdea7c71 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 09:07:58.0355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wEofhwRfcOLy1DkXRw7Btf/JwN9qMRbYtEEj5i1tRKAc9vX1ycm3YTf5qyVJiLJO X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8360 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/22/2023 10:52 AM, David Marchand wrote: > Hi Ferruh, Thomas, > > On Fri, Jan 20, 2023 at 6:19 PM Ferruh Yigit wrote: >> >> There was a plan to have structures from lib/net/ at the beginning >> of corresponding flow item structures. >> Unfortunately this plan has not been followed up so far. >> This series is a step to make the most used items, >> compliant with the inheritance design explained above. >> The old API is kept in anonymous union for compatibility, >> but the code in drivers and apps is updated to use the new API. >> >> >> v2: (by Ferruh) >> * Rebased on latest next-net for v23.03 >> * 'struct rte_gre_hdr' endianness annotation added to protocol field >> * more driver code updated for rte_flow_item_eth & rte_flow_item_vlan >> * 'struct rte_gre_hdr' updated to have a combined "rte_be16_t c_rsvd0_ver" >> field and updated drivers accordingly >> * more driver code updated for rte_flow_item_gre >> * more driver code updated for rte_flow_item_gtp >> >> >> Cc: David Marchand > > Note: it is relatively easy to run OVS checks, you only need a github > fork of ovs with a dpdk-latest branch + some github yml update to > point at a dpdk repo + branch of yours (see the last commit in my repo > below). > > I ran this series in my dpdk-latest (rebased) OVS branch > https://github.com/david-marchand/ovs/commits/dpdk-latest, through > GHA. > > Sparse spotted an issue on rte_flow.h header, following HIGIG2 update. > https://github.com/david-marchand/ovs/actions/runs/3979243283/jobs/6821543439#step:12:2592 > > 2023-01-22T10:31:37.5911785Z ../../lib/ofp-packet.c: note: in included > file (through ../../lib/netdev-dpdk.h, ../../lib/dp-packet.h): > 2023-01-22T10:31:37.5918848Z > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:645:43: > error: incorrect type in initializer (different base types) > 2023-01-22T10:31:37.5919574Z > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:645:43: > expected restricted ovs_be16 [usertype] classification > 2023-01-22T10:31:37.5920131Z > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:645:43: > got int > 2023-01-22T10:31:37.5920720Z > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:646:32: > error: incorrect type in initializer (different base types) > 2023-01-22T10:31:37.5921341Z > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:646:32: > expected restricted ovs_be16 [usertype] vid > 2023-01-22T10:31:37.5921866Z > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:646:32: > got int > 2023-01-22T10:31:37.6042168Z make[2]: *** [Makefile:4681: > lib/ofp-packet.lo] Error 1 > 2023-01-22T10:31:37.6042717Z make[2]: *** Waiting for unfinished jobs.... > > This should be fixed with: > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index a215daa836..99f8340f82 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -642,8 +642,8 @@ struct rte_flow_item_higig2_hdr { > static const struct rte_flow_item_higig2_hdr rte_flow_item_higig2_hdr_mask = { > .hdr = { > .ppt1 = { > - .classification = 0xffff, > - .vid = 0xfff, > + .classification = RTE_BE16(0xffff), > + .vid = RTE_BE16(0xfff), > }, > }, > }; > > However, looking at existing code, and though I don't know HIGIG2, it > is a bit strange to use a 12 bits large mask for vid. > > > With this fix, OVS sparse check passes: > https://github.com/david-marchand/ovs/actions/runs/3979288868 > > Thanks David, fixed this as you suggested in v3: https://patches.dpdk.org/project/dpdk/list/?series=26632 @Thomas, @Andrew, can we get this set for this release, what do you think?